[PATCH] [Lit] Use multiprocessing instead of threading

Chandler Carruth chandlerc at gmail.com
Wed Aug 28 18:09:17 PDT 2013


On Wed, Aug 28, 2013 at 6:00 PM, Daniel Dunbar <daniel at zuster.org> wrote:

>
>   Hi Takumi,
>
>   I just pushed an implementation of multiprocessing in lit, currently
>   available under the --use-processes command line flag.
>

Orthogonal to the specific feature, could you try to commit more
incrementally? Pushing a large set of changes is really hard to review, and
in other cases negatively impacts our build bot infrastructure. Also, it
can avoid folks duplicating effort because they aren't aware that you're
working on something in the background.


>
>   If you have a moment, could you rerun your previous timings (or similar)
> to
>   confirm that the version I pushed shows the same improvements you
>   originally reported?
>
>   Also, I haven't yet tested this feature on Windows, so I would love to
> hear
>   if it works and what the performance impact is. Fundamentally it has the
>   same pickling issues as before so if you previously found that to be a
>   bottleneck then it may continue to be a problem.
>
>    - Daniel
>
> http://llvm-reviews.chandlerc.com/D134
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20130828/0b069b0b/attachment.html>


More information about the llvm-commits mailing list