[PATCH] Teach LoopIdiom about address spaces

Eli Friedman eli.friedman at gmail.com
Wed Aug 28 14:06:24 PDT 2013


  In terms of the tests, it looks like you copy-pasted a bunch of tests and just changed the address spaces, so they aren't really testing anything new.  I'll leave it up to your judgement, though.


================
Comment at: lib/Transforms/Scalar/LoopIdiomRecognize.cpp:1028
@@ +1027,3 @@
+    if (DestAS != 0)
+      return false;
+
----------------
This check is too late; we want to check this before we start expanding the arguments.


http://llvm-reviews.chandlerc.com/D1462



More information about the llvm-commits mailing list