[PATCH] Start fleshing out the Darwin driver

Joe Ranieri joe at alacatialabs.com
Tue Aug 27 21:54:46 PDT 2013


On Sat, Aug 24, 2013 at 11:46 AM, Nick Kledzik <kledzik at apple.com> wrote:
>
> Think of validateImpl() as a check for the whole MachOLinkingContext which could have been created programmatically instead of through the driver. If the current_version in that struct is not the default value and the output type is not a dylib, then validateImpl() should warn/error that current_version won't be used.
>
> In the Driver, the first thing it checks for is the output type, so when you get to -current_version farther down in the source, you can check if the output type is not a dylib and if not issue a warning/error.
>
> -Nick

Okay, here is a series of patches for you to review:
* The first patch, darwin_packed_version.diff, eliminates
PackedVersion and introduces a helper function to parse a version into
an uint32_t. I did not add a helper function to go in reverse because
there currently is no need.
* The second patch, darwin_options2.diff, adds support for the six
options in the original patch. I believe it takes into account the
feedback given so far.
* The third patch, darwin_help.diff, makes the -help option actually
work without having to specify input files.

-- Joe Ranieri
-------------- next part --------------
A non-text attachment was scrubbed...
Name: darwin_packed_version.diff
Type: application/octet-stream
Size: 5015 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20130828/77948b49/attachment.obj>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: darwin_options2.diff
Type: application/octet-stream
Size: 10809 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20130828/77948b49/attachment-0001.obj>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: darwin_help.diff
Type: application/octet-stream
Size: 1232 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20130828/77948b49/attachment-0002.obj>


More information about the llvm-commits mailing list