MSBuild Integration files for drop-selecting LLVM as a toolchain in Visual Studio

[Aaron Ballman]

Thanks for the explanation -- LGTM!

~Aaron

On Tue, Aug 27, 2013 at 6:39 PM, Warren Hunt <whunt at google.com> wrote:
> Those weren't actually used, so I put something there to suppress warnings
> generated by the build system (those values get used elsewhere for
> somethings that's not important to clang).  I've updated the patch to
> suppress the warnings more explicitly.
>
> I changed the path from bin to msbuild-bin
>
> The fixed registry key location is left as a TODO.  We probably want to have
> the build system create this file with the current version number and have
> the installer also use the current version number to select the destination
> folder.
>
> -Warren
>
>
> On Tue, Aug 27, 2013 at 3:26 PM, Aaron Ballman <aaron at aaronballman.com>
> wrote:
>>
>> On Tue, Aug 27, 2013 at 6:16 PM, Reid Kleckner <rnk at google.com> wrote:
>> > It seems reasonable for these to have DOS line endings.  Do they need to
>> > have a BOM, though?
>> >
>> > +    <ClangInstallDir>$(Registry:HKEY_LOCAL_MACHINE\SOFTWARE\LLVM\LLVM
>> > 3.4.svn)</ClangInstallDir>
>> >
>> > Should this be looking for "LLVM 3.4.svn" specifically, or is there a
>> > way to
>> > be more generic?
>> >
>> > +
>> >
>> > <ExecutablePath>$(ClangInstallDir)\bin;$(ExecutablePath)</ExecutablePath>
>> >
>> > We should probably add a new directory like msbuild-bin instead, since
>> > we
>> > really don't want to place a clang binary named cl.exe into bin/.
>> >
>> >
>> >
>> > On Tue, Aug 27, 2013 at 3:05 PM, Warren Hunt <whunt at google.com> wrote:
>> >>
>> >> Attached is a patch with the requisite files to integrate a
>> >> drop-selectable llvm tool-chain in Visual Studio.  The files need to be
>> >> copied to:
>> >>
>> >> C:\Program Files
>> >> (x86)\MSBuild\Microsoft.Cpp\v4.0\Platforms\Win32\PlatformToolsets\llvm
>> >> on a 64 bit machine
>> >>
>> >> or
>> >>
>> >> C:\Program
>> >> Files\MSBuild\Microsoft.Cpp\v4.0\Platforms\Win32\PlatformToolsets\llvm
>> >> on a 32 bit machine
>> >>
>> >> or wherever MSBuild is installed.  This information can be obtained
>> >> from
>> >> the registry if desired.
>>
>> Would it make sense for us to add something to automatically perform
>> the copy for the user?
>>
>> > +    <WindowsSdkDir Condition="'$(UseEnv)' !=
>> > 'true'">$(Registry:HKEY_LOCAL_MACHINE\SOFTWARE\Microsoft\Microsoft
>> > SDKs\Windows\v7.0A at InstallationFolder)</WindowsSdkDir>
>> > +    <WindowsSdkDir Condition="'$(WindowsSdkDir)' ==
>> > ''">$(Registry:HKEY_LOCAL_MACHINE\SOFTWARE\Wow6432Node\Microsoft\Microsoft
>> > SDKs\Windows\v7.0A at InstallationFolder)</WindowsSdkDir>
>>
>> What about SDK dirs other than 7.0A?
>>
>> ~Aaron
>
>