[PATCH] Option parsing: support case-insensitive option matching.

Chandler Carruth chandlerc at google.com
Tue Aug 27 15:04:44 PDT 2013


On Tue, Aug 27, 2013 at 2:57 PM, Reid Kleckner <rnk at google.com> wrote:

>   LGTM
>
>   There's still a circular dependence here that you're avoiding with
> inline functions, but the only way to avoid it is by putting this string
> comparison into Support, which I don't like.
>

Please do not create circular dependencies with header files and rely on
inline functions. This breaks build systems, modules, and sanity.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20130827/358f7543/attachment.html>


More information about the llvm-commits mailing list