[llvm] r189315 - Move everything depending on Object/MachOFormat.h over to Support/MachO.h.

Nick Kledzik kledzik at apple.com
Tue Aug 27 15:03:58 PDT 2013


Chip,

Did you save off the error log of what failed with the change?  The builtbot website only seems to go back to 6am this morning, so I can’t see the failure anymore.  My guess is the problem is with relocation records which use bit fields and are thus painful to get cross-endianness right.  

-Nick

On Aug 26, 2013, at 10:41 PM, Charles Davis <cdavis5x at gmail.com> wrote:
> On Aug 26, 2013, at 11:32 PM, Charles Davis wrote:
>> On Aug 26, 2013, at 11:19 PM, David Blaikie wrote:
>> 
>>> On Mon, Aug 26, 2013 at 10:00 PM, Charles Davis <cdavis5x at gmail.com> wrote:
>>>> Author: cdavis
>>>> Date: Tue Aug 27 00:00:43 2013
>>>> New Revision: 189315
>>>> 
>>>> URL: http://llvm.org/viewvc/llvm-project?rev=189315&view=rev
>>>> Log:
>>>> Move everything depending on Object/MachOFormat.h over to Support/MachO.h.
>>> 
>>> There seem to be a number of unrelated changes in this patch -
>>> especially for such a large change, please commit the mechanical
>>> portion separately from any other cleanup/changes.
>> Sorry. Would you like me to revert this particular change?
> I went ahead and reverted it (and r189319) in r189321. It looks like it also broke the tests on some platforms (specifically System z and PowerPC--endianness issue? I don't have a big endian machine to test with, so...).
> 
> Chip
> 
> 
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits





More information about the llvm-commits mailing list