[PATCH] [ARMv8] Load/Store Acquire/Release instructions

Tim Northover t.p.northover at gmail.com
Tue Aug 27 09:18:45 PDT 2013


  I think it's basically fine. Just a couple of formatting issues that I spotted.


================
Comment at: lib/Target/ARM/ARMInstrThumb2.td:1580-1582
@@ +1579,5 @@
+
+def t2STL  : T2Istrrel<0b10, (outs rGPR:$Rt), (ins addr_offset_none:$addr), "stl", "\t$Rt, $addr", []>;
+def t2STLB : T2Istrrel<0b00, (outs rGPR:$Rt), (ins addr_offset_none:$addr), "stlb", "\t$Rt, $addr", []>;
+def t2STLH : T2Istrrel<0b01, (outs rGPR:$Rt), (ins addr_offset_none:$addr), "stlh", "\t$Rt, $addr", []>;
+
----------------
Looks like these are > 80 chars

================
Comment at: lib/Target/ARM/ARMInstrThumb2.td:3299-3303
@@ +3298,7 @@
+def t2STREXH
+    : T2I_strex<0b0101, (outs rGPR
+                             : $Rd),
+                (ins rGPR
+                 : $Rt, addr_offset_none
+                 : $addr),
+                AddrModeNone, 4, NoItinerary, "strexh", "\t$Rd, $Rt, $addr", "",
----------------
Whaaaa?


http://llvm-reviews.chandlerc.com/D1530



More information about the llvm-commits mailing list