[PATCH][X86_64/MC] Fix code offset for unwind code SET_FPREG and enable test

Kai Nacke kai.nacke at redstar.de
Mon Aug 26 21:20:44 PDT 2013


On 26.08.2013 18:41, Jim Grosbach wrote:
> I have no objection.
>
> -Jim

Thanks. Committed in r189309.

Regards
Kai

>
> On Aug 25, 2013, at 9:21 PM, Kai Nacke <kai.nacke at redstar.de> wrote:
>
>> Please, could have one of the MC maintainers a look at my patch? Thank you!
>>
>> Regards
>> Kai
>>
>> On 20.08.2013 14:34, Charles Davis wrote:
>>>
>>> On Aug 12, 2013, at 12:07 AM, Kai Nacke wrote:
>>>
>>>> Hi!
>>>>
>>>> The code offset for unwind code SET_FPREG is wrong because it
>>>> is set to constant 0. The fix is to do the same as for the other
>>>> unwind codes: emit a label and later the absolute difference
>>>> between the label and the begin of the prologue.
>>>>
>>>> The attached patch fixes the issue and enables the associated test.
>>>>
>>>> Please review.
>>> LGTM.
>>>
>>> Chip
>>>
>>>>
>>>> Regards
>>>>
>>>> Kai
>>>> <0001-Fix-failing-test-seh.s.patch>_______________________________________________
>>>> llvm-commits mailing list
>>>> llvm-commits at cs.uiuc.edu
>>>> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
>>>
>>>
>>> _______________________________________________
>>> llvm-commits mailing list
>>> llvm-commits at cs.uiuc.edu
>>> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
>>>
>>
>> <0001-Fix-failing-test-seh.s.patch>
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
>




More information about the llvm-commits mailing list