[PATCH] GlobalOpt enhancement optimization (hoisting of initialization code into constant global initializers).

[Nick Lewycky]

On 26 August 2013 12:00, Puyan Lotfi <plotfi at apple.com> wrote:

> Test cases attached along with patch.
>

The testcases should actually be part of the patch. If you're using svn,
"svn add" the testcase files, and they'll show up when you run svn diff.

Nick

On Aug 26, 2013, at 8:06 AM, Meador Inge <meadori at codesourcery.com> wrote:
>
> > On 08/26/2013 03:40 AM, Puyan Lotfi wrote:
> >
> >> Could someone on the list review my changes, provide feedback, and if
> possible
> >> submit my changes?
> >>
> >> I also have some test cases I've written but I am still trying to
> figure out how
> >> to add them to llvm/test/Transforms/GlobalOpt (I don't see a
> lit.local.cfg in
> >> that directory as the docs specify).
> >
> > Folks can provide feedback given just the patch, but it will be easier to
> > review with the test cases as a part of the code change patch.  Also, it
> > shouldn't be committed without the test cases.  So, I would get the test
> case
> > changes worked out and re-submit.
> >
> > --
> > Meador Inge
> > CodeSourcery / Mentor Embedded
>
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20130826/2e42fce6/attachment.html>