[PATCH] handle typeZeroFill atoms in ELF/Native/YAML

kledzik at apple.com kledzik at apple.com
Thu Aug 22 12:11:52 PDT 2013


  We may want to add a DefinedAtom::isZeroFillContent() utility method that does the check for all ContentTypes that are zero fill, rather than having that ==  || == || == test repeated in lots of places.


================
Comment at: test/elf/X86_64/largebss.test:20-24
@@ +19,6 @@
+CHECK:    section-name:    .bss
+CHECK:  - name:            largetbss
+CHECK:    scope:           global
+CHECK:    type:            tlv-zero-fill
+CHECK:    size:            4000
+CHECK:    section-name:    .tbss
----------------
The Atom::ContentTypes type*TLV* and were are added for Darwin which has a different model for thread locals that ELF.  You many want to review the ELF model to see if a different set of ContentTypes need to be added to support the ELF model, rather than trying to re-use the darwin types.


http://llvm-reviews.chandlerc.com/D1469



More information about the llvm-commits mailing list