[llvm] r189026 - Autoconf: The Clang ARC migrator now depends on the static analyzer.

[Eric Christopher]

On Thu, Aug 22, 2013 at 8:49 AM, Jordan Rose <jordan_rose at apple.com> wrote:
> Author: jrose
> Date: Thu Aug 22 10:49:53 2013
> New Revision: 189026
>
> URL: http://llvm.org/viewvc/llvm-project?rev=189026&view=rev
> Log:
> Autoconf: The Clang ARC migrator now depends on the static analyzer.
>

Weird.

> I don't actually have a version of autoconf so I edited configure directly
> as well. It's copy-pasted so I think there was little margin for error.
>

Getting the correct versions really only takes a couple of minutes...
the edits you made were fine, but I'll caution against it in the
future.

-eric

> See also Clang-side dependency graph changes.
>
> Modified:
>     llvm/trunk/autoconf/configure.ac
>     llvm/trunk/configure
>
> Modified: llvm/trunk/autoconf/configure.ac
> URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/autoconf/configure.ac?rev=189026&r1=189025&r2=189026&view=diff
> ==============================================================================
> --- llvm/trunk/autoconf/configure.ac (original)
> +++ llvm/trunk/autoconf/configure.ac Thu Aug 22 10:49:53 2013
> @@ -551,7 +551,12 @@ AC_ARG_ENABLE(clang-static-analyzer,
>                               enableval="yes")
>  case "$enableval" in
>    yes) AC_SUBST(ENABLE_CLANG_STATIC_ANALYZER,[1]) ;;
> -  no)  AC_SUBST(ENABLE_CLANG_STATIC_ANALYZER,[0]) ;;
> +  no)
> +    if test ${clang_arcmt} != "no" ; then
> +      AC_MSG_ERROR([Cannot enable clang ARC Migration Tool while disabling static analyzer.])
> +    fi
> +    AC_SUBST(ENABLE_CLANG_STATIC_ANALYZER,[0])
> +    ;;
>    default) AC_SUBST(ENABLE_CLANG_STATIC_ANALYZER,[1]);;
>    *) AC_MSG_ERROR([Invalid setting for --enable-clang-static-analyzer. Use "yes" or "no"]) ;;
>  esac
>
> Modified: llvm/trunk/configure
> URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/configure?rev=189026&r1=189025&r2=189026&view=diff
> ==============================================================================
> --- llvm/trunk/configure (original)
> +++ llvm/trunk/configure Thu Aug 22 10:49:53 2013
> @@ -5224,8 +5224,14 @@ fi
>  case "$enableval" in
>    yes) ENABLE_CLANG_STATIC_ANALYZER=1
>   ;;
> -  no)  ENABLE_CLANG_STATIC_ANALYZER=0
> - ;;
> +  no)
> +    if test ${clang_arcmt} != "no" ; then
> +      { { echo "$as_me:$LINENO: error: Cannot enable clang ARC Migration Tool while disabling static analyzer." >&5
> +echo "$as_me: error: Cannot enable clang ARC Migration Tool while disabling static analyzer." >&2;}
> +   { (exit 1); exit 1; }; }
> +    fi
> +    ENABLE_CLANG_STATIC_ANALYZER=0
> +    ;;
>    default) ENABLE_CLANG_STATIC_ANALYZER=1
>  ;;
>    *) { { echo "$as_me:$LINENO: error: Invalid setting for --enable-clang-static-analyzer. Use \"yes\" or \"no\"" >&5
>
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits