[PATCH] Start fleshing out the Darwin driver

Joe Ranieri joe at alacatialabs.com
Thu Aug 22 00:43:17 PDT 2013


Here is a patch that adds a handful of options to the Darwin driver.
There's only a few because I'd like to know if I'm on the right track or
not. I've tried to model the implementation and style off of the various
existing bits of drivers and linking contexts for each platform.

I have a few questions, I suspect most of which are for Nick:
- What should the granularity of the tests in DarwinLdDriverTest.cpp be?
For now I've put all of the new dylib flags into the "Dylib" test instead
of each flag getting its own test. This seems to mirror
WinLinkDriverTest.cpp's "Basic" test, though it also has tests for
individual options.
- Are the doxygen in MachOLinkingContext too verbose? Should they just be
basic setters/getter pairs with no comments, like PECOFFLinkingContext?
- How should the dylib compatibility and current version flags be stored?
The minimum OS version is immediately validated outside of validateImpl and
stored into a PackedVersion. There is no getter to access the exact value
for that field, just the minOS helper.
- What are the style guidelines for the tablegen files and the unit tests?
The LDOptions.td file seem to disregard the 80 column idea completely.

-- Joe Ranieri
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20130822/dbc818f9/attachment.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: ld64_options1.diff
Type: application/octet-stream
Size: 11111 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20130822/dbc818f9/attachment.obj>


More information about the llvm-commits mailing list