[PATCH] CMake: add LLVM_INSTALL_DEV_FILES variable

Hans Wennborg hans at chromium.org
Wed Aug 21 18:38:11 PDT 2013


On Wed, Aug 21, 2013 at 6:32 PM, Chandler Carruth <chandlerc at google.com> wrote:
>> >> Quite possibly... Can we avoid installing llvm-lit as well? (probably
>> >> ask
>> >> Jordan?) If so, then SGTM.
>> >
>> > Yes, I believe so. After chatting with Michael, I don't think there
>> > are builds that rely on llvm-lit being installed.
>> >
>> > I'd like to go ahead and start this off by removing llvm-lit and the
>> > tablegens from the install (patch attached) to make sure nothing
>> > breaks and no one gets upset. OK to commit?
>>
>> Actually, let's start with removing only llvm-lit.
>
>
> LGTM, please commit.

r188976

>> Turns out clang (and lld too) depends on llvm-tblgen for generating
>> the option parsing tables. It even uses the existence of llvm-tblgen
>> to detect a valid "build or install" directory for llvm :/
>
>
> It would seem better to use llvm-config.
>
>>
>> I guess one could argue that the option parsing stuff, including
>> generating the tables, is part of llvm's functionality as a library.
>> The rests of what llvm-tblgen does seems pretty internal to llvm
>> though.
>
>
> I think it is all internal. The option parsing stuff is definitely internal.
> I think that clang and lld should use llvm-tblgen (if they need it) out of
> the llvm build tree just like they use lit out of that tree. I think they
> can find it with llvm-config?

Sounds like a plan. I'll look into it.



More information about the llvm-commits mailing list