[llvm] r188843 - Use -disable-output and to suppress output and don't use a temporary file unless we need one.

Bill Wendling isanbard at gmail.com
Tue Aug 20 16:26:00 PDT 2013


On Aug 20, 2013, at 4:10 PM, David Blaikie <dblaikie at gmail.com> wrote:

> On Tue, Aug 20, 2013 at 4:00 PM, Bill Wendling <isanbard at gmail.com> wrote:
>> Author: void
>> Date: Tue Aug 20 18:00:25 2013
>> New Revision: 188843
>> 
>> URL: http://llvm.org/viewvc/llvm-project?rev=188843&view=rev
>> Log:
>> Use -disable-output and to suppress output and don't use a temporary file unless we need one.
> 
> What do these tests even do if they're not printing any output? I
> guess they run the verifier?

That would be my guess. Or at least to ensure that it can be optimized and disassembled. I'm guessing these tests are ancient.

> Could we make that more explicit in some
> way? (should 'opt' have an option for running the verifier on its
> output (I assume it runs it on its input already)?)
> 
We could specify the `-verify' option I suppose?

-bw

>> 
>> Modified:
>>    llvm/trunk/test/Bitcode/extractelement.ll
>>    llvm/trunk/test/Bitcode/metadata-2.ll
>>    llvm/trunk/test/Bitcode/metadata.ll
>>    llvm/trunk/test/Bitcode/null-type.ll
>>    llvm/trunk/test/Bitcode/shuffle.ll
>> 
>> Modified: llvm/trunk/test/Bitcode/extractelement.ll
>> URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/test/Bitcode/extractelement.ll?rev=188843&r1=188842&r2=188843&view=diff
>> ==============================================================================
>> --- llvm/trunk/test/Bitcode/extractelement.ll (original)
>> +++ llvm/trunk/test/Bitcode/extractelement.ll Tue Aug 20 18:00:25 2013
>> @@ -1,4 +1,4 @@
>> -; RUN: opt < %s -constprop | llvm-dis
>> +; RUN: opt < %s -constprop | llvm-dis -disable-output
>> ; PR3465
>> 
>> define double @test() {
>> 
>> Modified: llvm/trunk/test/Bitcode/metadata-2.ll
>> URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/test/Bitcode/metadata-2.ll?rev=188843&r1=188842&r2=188843&view=diff
>> ==============================================================================
>> --- llvm/trunk/test/Bitcode/metadata-2.ll (original)
>> +++ llvm/trunk/test/Bitcode/metadata-2.ll Tue Aug 20 18:00:25 2013
>> @@ -1,4 +1,4 @@
>> -; RUN: llvm-as < %s | llvm-dis -o /dev/null
>> +; RUN: llvm-as < %s | llvm-dis -disable-output
>>        %0 = type { %object.ModuleInfo.__vtbl*, i8*, %"byte[]", %1, %"ClassInfo[]", i32, void ()*, void ()*, void ()*, i8*, void ()* }          ; type %0
>>        %1 = type { i64, %object.ModuleInfo* }          ; type %1
>>        %2 = type { i32, void ()* }             ; type %2
>> 
>> Modified: llvm/trunk/test/Bitcode/metadata.ll
>> URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/test/Bitcode/metadata.ll?rev=188843&r1=188842&r2=188843&view=diff
>> ==============================================================================
>> --- llvm/trunk/test/Bitcode/metadata.ll (original)
>> +++ llvm/trunk/test/Bitcode/metadata.ll Tue Aug 20 18:00:25 2013
>> @@ -1,6 +1,5 @@
>> -; RUN: llvm-as < %s | llvm-dis -o /dev/null
>> +; RUN: llvm-as < %s | llvm-dis -disable-output
>> 
>> !llvm.foo = !{!0}
>> !0 = metadata !{i32 42}
>> @my.str = internal constant [4 x i8] c"foo\00"
>> -
>> 
>> Modified: llvm/trunk/test/Bitcode/null-type.ll
>> URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/test/Bitcode/null-type.ll?rev=188843&r1=188842&r2=188843&view=diff
>> ==============================================================================
>> --- llvm/trunk/test/Bitcode/null-type.ll (original)
>> +++ llvm/trunk/test/Bitcode/null-type.ll Tue Aug 20 18:00:25 2013
>> @@ -1,5 +1,4 @@
>> -; RUN: not llvm-dis < %s.bc > /dev/null 2> %t
>> -; RUN: FileCheck %s < %t
>> +; RUN: not llvm-dis < %s.bc 2>&1 | FileCheck %s
>> ; PR8494
>> 
>> ; CHECK: Invalid MODULE_CODE_FUNCTION record
>> 
>> Modified: llvm/trunk/test/Bitcode/shuffle.ll
>> URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/test/Bitcode/shuffle.ll?rev=188843&r1=188842&r2=188843&view=diff
>> ==============================================================================
>> --- llvm/trunk/test/Bitcode/shuffle.ll (original)
>> +++ llvm/trunk/test/Bitcode/shuffle.ll Tue Aug 20 18:00:25 2013
>> @@ -1,4 +1,4 @@
>> -; RUN: llvm-as < %s | llvm-dis
>> +; RUN: llvm-as < %s | llvm-dis -disable-output
>> 
>> ; <rdar://problem/8622574>
>> ; tests the bitcodereader can handle the case where the reader will initially
>> 
>> 
>> _______________________________________________
>> llvm-commits mailing list
>> llvm-commits at cs.uiuc.edu
>> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits





More information about the llvm-commits mailing list