[PATCH] [mips][msa] Removed fcge, fcgt, fsge, fsgt

[Jack Carter]

LGTM

Jack
________________________________________
From: Daniel Sanders
Sent: Monday, August 19, 2013 2:33 AM
To: Hal Finkel
Cc: llvm-commits at cs.uiuc.edu; Jack Carter
Subject: RE: [PATCH] [mips][msa] Removed fcge, fcgt, fsge, fsgt

I agree. I've updated the patch with a better commit message.

> -----Original Message-----
> From: Hal Finkel [mailto:hfinkel at anl.gov]
> Sent: 19 August 2013 10:11
> To: Daniel Sanders
> Cc: llvm-commits at cs.uiuc.edu; Jack Carter
> Subject: Re: [PATCH] [mips][msa] Removed fcge, fcgt, fsge, fsgt
>
> ----- Original Message -----
> > Hi,
> >
> > There's no existing hardware that supported these instructions. Some
> > of our unreleased software models supported them but these have also
> > been updated to the match the published version of the MSA spec.
>
> Sounds good. Personally, I think that you should note that somehow in the
> commit log (maybe call it a draft spec) just so that bystanders understand
> what's going on.
>
>  -Hal
>
> >
> > > -----Original Message-----
> > > From: Hal Finkel [mailto:hfinkel at anl.gov]
> > > Sent: 16 August 2013 17:46
> > > To: Daniel Sanders
> > > Cc: llvm-commits at cs.uiuc.edu; Jack Carter
> > > Subject: Re: [PATCH] [mips][msa] Removed fcge, fcgt, fsge, fsgt
> > >
> > > ----- Original Message -----
> > > >
> > > >
> > > >
> > > >
> > > > Removed support for fcge, fcgt, fsge, and fsgt. These were present
> > > > in older versions of the spec but were removed in r1.04.
> > >
> > > Out of curiosity, are you removing support for instructions that are
> > > implemented in current in-production hardware?
> > >
> > >  -Hal
> > >
> > > >
> > > >
> > > >
> > > > Daniel Sanders
> > > >
> > > > Leading Software Design Engineer, MIPS Processor IP
> > > >
> > > > Imagination Technologies Limited
> > > >
> > > > www.imgtec.com
> > > >
> > > >
> > > > _______________________________________________
> > > > llvm-commits mailing list
> > > > llvm-commits at cs.uiuc.edu
> > > > http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
> > > >
> > >
> > > --
> > > Hal Finkel
> > > Assistant Computational Scientist
> > > Leadership Computing Facility
> > > Argonne National Laboratory
> >
>
> --
> Hal Finkel
> Assistant Computational Scientist
> Leadership Computing Facility
> Argonne National Laboratory