[compiler-rt] r188635 - It appears that glibc 2.13 has the same thread descriptor size as 2.11,

[Sergey Matveev]

> one LSan failure

What kind of failure?


On Sun, Aug 18, 2013 at 7:59 PM, David Blaikie <dblaikie at gmail.com> wrote:

> On Sun, Aug 18, 2013 at 3:04 AM, Chandler Carruth <chandlerc at gmail.com>
> wrote:
> > Author: chandlerc
> > Date: Sun Aug 18 05:04:51 2013
> > New Revision: 188635
> >
> > URL: http://llvm.org/viewvc/llvm-project?rev=188635&view=rev
> > Log:
> > It appears that glibc 2.13 has the same thread descriptor size as 2.11,
> > bump up the inflection point to 2.14. If someone can tell me how to
> > actually figure out value for this, that would be awesome.
> >
> > Anyways, this takes me to one ASan failure, one LSan failure, and three
> > TSan failures for 'check-all' on Linux.
>
> I've tried to not build compiler-rt all the time now to reduce my
> cycle time, but last time I did I saw, I believe, 3 TSan failures when
> using -gsplit-dwarf (which you mentioned you'd switched over to
> recently), if that's a useful data point.
>
> - David
>
> >
> > Modified:
> >     compiler-rt/trunk/lib/sanitizer_common/sanitizer_linux_libcdep.cc
> >
> > Modified:
> compiler-rt/trunk/lib/sanitizer_common/sanitizer_linux_libcdep.cc
> > URL:
> http://llvm.org/viewvc/llvm-project/compiler-rt/trunk/lib/sanitizer_common/sanitizer_linux_libcdep.cc?rev=188635&r1=188634&r2=188635&view=diff
> >
> ==============================================================================
> > --- compiler-rt/trunk/lib/sanitizer_common/sanitizer_linux_libcdep.cc
> (original)
> > +++ compiler-rt/trunk/lib/sanitizer_common/sanitizer_linux_libcdep.cc
> Sun Aug 18 05:04:51 2013
> > @@ -196,9 +196,9 @@ uptr GetTlsSize() {
> >
> >  #if defined(__x86_64__) || defined(__i386__)
> >  // sizeof(struct thread) from glibc.
> > -// There has been a report of this being different on glibc 2.11. We
> don't know
> > -// when this change happened, so 2.12 is a conservative estimate.
> > -#if __GLIBC_PREREQ(2, 12)
> > +// There has been a report of this being different on glibc 2.11 and
> 2.13. We
> > +// don't know when this change happened, so 2.14 is a conservative
> estimate.
> > +#if __GLIBC_PREREQ(2, 14)
> >  const uptr kThreadDescriptorSize = FIRST_32_SECOND_64(1216, 2304);
> >  #else
> >  const uptr kThreadDescriptorSize = FIRST_32_SECOND_64(1168, 2304);
> >
> >
> > _______________________________________________
> > llvm-commits mailing list
> > llvm-commits at cs.uiuc.edu
> > http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20130818/ecd301d8/attachment.html>