[PATCH] Weak symbols for COFF

Reid Kleckner rnk at google.com
Thu Aug 15 09:59:48 PDT 2013


  LGTM


================
Comment at: lib/MC/WinCOFFObjectWriter.cpp:638
@@ +637,3 @@
+  const MCSymbolData &SymbolData = Asm.getSymbolData(Symbol);
+  // For a weak external the relocation must not use the aliased symbol to allow
+  // replacing it at link time.
----------------
Hm, I wonder if I affected this in r186341.


http://llvm-reviews.chandlerc.com/D1309

BRANCH
  arc/coff-weak

ARCANIST PROJECT
  llvm



More information about the llvm-commits mailing list