[PATCH]Clang and AArch64 backend patches to support sshll/ushll instructions

Joey Gouly Joey.Gouly at arm.com
Wed Aug 14 11:36:42 PDT 2013


Hi Hao,

One minor thing before you commit:

+/// Getvshiftimm - Check if this is a valid build_vector for the immediate
+/// isVShiftLImm - Check if this is a valid build_vector for the immediate

Don't include the name of the function in the comment.

Thanks,
Joey

________________________________________
From: llvm-commits-bounces at cs.uiuc.edu [llvm-commits-bounces at cs.uiuc.edu] On Behalf Of Tim Northover [t.p.northover at gmail.com]
Sent: 14 August 2013 19:15
To: Hao Liu
Cc: Jiangning Liu; llvm-commits
Subject: Re: [PATCH]Clang and AArch64 backend patches to support sshll/ushll    instructions

Hi Hao,

Thanks for that. The patches look good to me now. Go ahead and commit.

Cheers.

Tim.
_______________________________________________
llvm-commits mailing list
llvm-commits at cs.uiuc.edu
http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits


-- IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium.  Thank you.

ARM Limited, Registered office 110 Fulbourn Road, Cambridge CB1 9NJ, Registered in England & Wales, Company No:  2557590
ARM Holdings plc, Registered office 110 Fulbourn Road, Cambridge CB1 9NJ, Registered in England & Wales, Company No:  2548782





More information about the llvm-commits mailing list