[llvm] r188351 - [CMake] add_llvm_library: Specify explicit suffix .imp to import library to avoid a warning between profile_rt-static and profile_rt-shared with lib/profile_rt.lib.

[Reid Kleckner]

Thanks for actually tracking this down!  I've been meaning to do it for
months, but eventually I just forgot about it...


On Tue, Aug 13, 2013 at 8:34 PM, NAKAMURA Takumi <geek4civic at gmail.com>wrote:

> Author: chapuni
> Date: Tue Aug 13 22:34:49 2013
> New Revision: 188351
>
> URL: http://llvm.org/viewvc/llvm-project?rev=188351&view=rev
> Log:
> [CMake] add_llvm_library: Specify explicit suffix .imp to import library
> to avoid a warning between profile_rt-static and profile_rt-shared with
> lib/profile_rt.lib.
>
> FIXME: It seems MS version of profile_rt.dll doesn't contain any export
> symbols.
>
> Modified:
>     llvm/trunk/cmake/modules/AddLLVM.cmake
>
> Modified: llvm/trunk/cmake/modules/AddLLVM.cmake
> URL:
> http://llvm.org/viewvc/llvm-project/llvm/trunk/cmake/modules/AddLLVM.cmake?rev=188351&r1=188350&r2=188351&view=diff
>
> ==============================================================================
> --- llvm/trunk/cmake/modules/AddLLVM.cmake (original)
> +++ llvm/trunk/cmake/modules/AddLLVM.cmake Tue Aug 13 22:34:49 2013
> @@ -12,6 +12,11 @@ macro(add_llvm_library name)
>
>    if( BUILD_SHARED_LIBS )
>      llvm_config( ${name} ${LLVM_LINK_COMPONENTS} )
> +    if (MSVC)
> +      set_target_properties(${name}
> +        PROPERTIES
> +        IMPORT_SUFFIX ".imp")
> +    endif ()
>    endif()
>
>    # Ensure that the system libraries always comes last on the
>
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20130814/57ff1603/attachment.html>