[PATCH] [RFC] Deprecated feature in TableGen

[Tim Northover]

  Hi Joey,

  I'm not convinced the three instructions ARM is deprecating really warrant a change like this. TableGen is hairy enough as it is, without adding barely used features. Of course, there could be hundreds of uses in other architectures, just waiting for something like this; that would obviously change things.


================
Comment at: tools/llvm-mc/Disassembler.cpp:90
@@ -88,1 +89,3 @@
     case MCDisassembler::Success:
+      if (MII.get(Inst.getOpcode()).isDeprecated(Inst, STI))
+        Streamer.AddComment(Twine("DEPRECATED"));
----------------
I think this is the line I'm most worried about. It seems rather ad-hoc. I wonder if a more general "CustomComment" method (plumbed in somewhere else, obviously) might solve this and the potential limited applicability of deprecation as a concept.


http://llvm-reviews.chandlerc.com/D1399