[PATCH] Add ALL to FileCheck

Robinson, Paul Paul_Robinson at playstation.sony.com
Tue Aug 13 09:35:13 PDT 2013


+1 here.  I had to write a test once with lots of duplicate checking lines,
being able to specify multiple prefixes would make things lots easier.
Redefining CHECK as the default iff you don't say anything else makes sense too.
--paulr

From: llvm-commits-bounces at cs.uiuc.edu [mailto:llvm-commits-bounces at cs.uiuc.edu] On Behalf Of Renato Golin
Sent: Tuesday, August 13, 2013 9:29 AM
To: Stephen Lin
Cc: reviews+D1374+public+721da8dd7b49ee6f at llvm-reviews.chandlerc.com; LLVM Commits
Subject: Re: [PATCH] Add ALL to FileCheck

On 13 August 2013 17:11, Stephen Lin <swlin at post.harvard.edu<mailto:swlin at post.harvard.edu>> wrote:
Exactly, my suggestion is for multiple prefixes only, and not ALL or
any other prefix that is turned on in all cases. Only "CHECK" is
grandfathered is as an implicit prefix, and it is only used in the
case that no other prefix is provided.

Ok, that makes sense. I think I prefer this way, too.

Matt, do you have any views on this? Anyone else?

cheers,
--renato
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20130813/7fa1f3a1/attachment.html>


More information about the llvm-commits mailing list