[PATCH] Define SANITIZER_INTERFACE_ATTRIBUTE on Windows and fix all the usages of this macro

Timur Iskhodzhanov timurrrr at google.com
Mon Aug 12 09:53:30 PDT 2013



================
Comment at: asan/asan_interface_internal.h:110
@@ -108,3 +109,3 @@
   /* OPTIONAL */ void __asan_on_error()
-      SANITIZER_WEAK_ATTRIBUTE SANITIZER_INTERFACE_ATTRIBUTE;
+      SANITIZER_WEAK_ATTRIBUTE;
 
----------------
Alexey Samsonov wrote:
> Why not move SANITIZER_WEAK_ATTRIBUTE before the function declaration as well for consistency?
I'm not sure what exact "weak" attribute we'll use on Windows, so I'd like to postpone this decision.

================
Comment at: tsan/rtl/tsan_interceptors.cc:372
@@ -373,1 +371,3 @@
+SANITIZER_INTERFACE_ATTRIBUTE
+extern "C" int __interceptor_setjmp(void *env);
 extern "C" int __interceptor_setjmp(void *env) {
----------------
Alexey Samsonov wrote:
> Alright. Can we:
> 1) use common extern "C" {} for all these interceptors?
> 2) have only a definition, w/o additional declaration? Specifying attributes before the
> function definition should be fine.
(2) Sounds good to me.
Dmitry, any objections?


http://llvm-reviews.chandlerc.com/D1364



More information about the llvm-commits mailing list