[llvm] r188082 - DebugInfo: provide the ability to add members to a class after it has been constructed

[Eric Christopher]

On Sat, Aug 10, 2013 at 12:51 PM, David Blaikie <dblaikie at gmail.com> wrote:
>
>
>
> On Fri, Aug 9, 2013 at 11:23 AM, Robinson, Paul
> <Paul_Robinson at playstation.sony.com> wrote:
>>
>> > -----Original Message-----
>> > From: llvm-commits-bounces at cs.uiuc.edu [mailto:llvm-commits-
>> > bounces at cs.uiuc.edu] On Behalf Of David Blaikie
>> > Sent: Friday, August 09, 2013 10:17 AM
>> > To: llvm-commits at cs.uiuc.edu
>> > Subject: [llvm] r188082 - DebugInfo: provide the ability to add members
>> > to a class after it has been constructed
>> >
>> > Author: dblaikie
>> > Date: Fri Aug  9 12:17:12 2013
>> > New Revision: 188082
>> >
>> > URL: http://llvm.org/viewvc/llvm-project?rev=188082&view=rev
>> > Log:
>> > DebugInfo: provide the ability to add members to a class after it has
>> > been constructed
>> >
>> > This is necessary to allow Clang to only emit implicit members when
>> > there is code generated for them, rather than whenever they are ODR
>> > used.
>>
>> Um, so classes could have different member lists in different TUs,
>> meaning if you're using type units, the type units won't match?
>

To pile onto this slightly, Dave and I have been talking to Cary a bit
about what to do about this. My opinion (that I believe Dave may
share) is that structure types may need to go to the namespace style
rather than as a complete record type. This is also unfortunate and
reducing size of debug information in linked binaries is going to
require at least some linker support, but I don't have any better
ideas at the moment.

-eric