[PATCH] [FileCheck] Fix a bug that cause FileCheck to misidentify check-prefix

Rui Ueyama ruiu at google.com
Fri Aug 9 11:12:57 PDT 2013


I agree that we should fix the tests. Can you do that in a separate patch?


On Fri, Aug 9, 2013 at 2:35 AM, Tim Northover <t.p.northover at gmail.com>wrote:

>
>   I think fixing the tests would be the best option. The FileCheck
> documentation doesn't sanction that kind of use (though it is a bit vague),
> so the tests are buggy. You should probably make your changes to the RUN
> line rather than each CHECK-XXX line though, where possible.
>
>   Best to minimise the impact of these sweeping changes.
>
>   Cheers.
>
>   Tim.
>
> http://llvm-reviews.chandlerc.com/D1271
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20130809/388f4115/attachment.html>


More information about the llvm-commits mailing list