[llvm] r187711 - Remove "lto_on_osx" xfails, now that -rdynamic works on Darwin.

Rafael EspĂ­ndola rafael.espindola at gmail.com
Fri Aug 9 08:24:19 PDT 2013


Awesome!

On 4 August 2013 19:55, Bob Wilson <bob.wilson at apple.com> wrote:
> Author: bwilson
> Date: Sun Aug  4 18:55:24 2013
> New Revision: 187711
>
> URL: http://llvm.org/viewvc/llvm-project?rev=187711&view=rev
> Log:
> Remove "lto_on_osx" xfails, now that -rdynamic works on Darwin.
>
> Note that this will require a recent version of the linker for Darwin
> builds with LTO to pass these tests.
>
> Modified:
>     llvm/trunk/test/BugPoint/crash-narrowfunctiontest.ll
>     llvm/trunk/test/BugPoint/metadata.ll
>     llvm/trunk/test/BugPoint/remove_arguments_test.ll
>     llvm/trunk/test/Feature/load_module.ll
>     llvm/trunk/test/lit.cfg
>
> Modified: llvm/trunk/test/BugPoint/crash-narrowfunctiontest.ll
> URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/test/BugPoint/crash-narrowfunctiontest.ll?rev=187711&r1=187710&r2=187711&view=diff
> ==============================================================================
> --- llvm/trunk/test/BugPoint/crash-narrowfunctiontest.ll (original)
> +++ llvm/trunk/test/BugPoint/crash-narrowfunctiontest.ll Sun Aug  4 18:55:24 2013
> @@ -2,7 +2,6 @@
>  ;
>  ; RUN: bugpoint -load %llvmshlibdir/BugpointPasses%shlibext %s -output-prefix %t -bugpoint-crashcalls -silence-passes > /dev/null
>  ; REQUIRES: loadable_module
> -; XFAIL: lto_on_osx
>
>  define i32 @foo() { ret i32 1 }
>
>
> Modified: llvm/trunk/test/BugPoint/metadata.ll
> URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/test/BugPoint/metadata.ll?rev=187711&r1=187710&r2=187711&view=diff
> ==============================================================================
> --- llvm/trunk/test/BugPoint/metadata.ll (original)
> +++ llvm/trunk/test/BugPoint/metadata.ll Sun Aug  4 18:55:24 2013
> @@ -1,7 +1,6 @@
>  ; RUN: bugpoint -load %llvmshlibdir/BugpointPasses%shlibext %s -output-prefix %t -bugpoint-crashcalls -silence-passes > /dev/null
>  ; RUN: llvm-dis %t-reduced-simplified.bc -o - | FileCheck %s
>  ; REQUIRES: loadable_module
> -; XFAIL: lto_on_osx
>
>  ; Bugpoint should keep the call's metadata attached to the call.
>
>
> Modified: llvm/trunk/test/BugPoint/remove_arguments_test.ll
> URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/test/BugPoint/remove_arguments_test.ll?rev=187711&r1=187710&r2=187711&view=diff
> ==============================================================================
> --- llvm/trunk/test/BugPoint/remove_arguments_test.ll (original)
> +++ llvm/trunk/test/BugPoint/remove_arguments_test.ll Sun Aug  4 18:55:24 2013
> @@ -1,7 +1,6 @@
>  ; RUN: bugpoint -load %llvmshlibdir/BugpointPasses%shlibext %s -output-prefix %t -bugpoint-crashcalls -silence-passes
>  ; RUN: llvm-dis %t-reduced-simplified.bc -o - | FileCheck %s
>  ; REQUIRES: loadable_module
> -; XFAIL: lto_on_osx
>
>  ; Test to make sure that arguments are removed from the function if they are
>  ; unnecessary. And clean up any types that that frees up too.
>
> Modified: llvm/trunk/test/Feature/load_module.ll
> URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/test/Feature/load_module.ll?rev=187711&r1=187710&r2=187711&view=diff
> ==============================================================================
> --- llvm/trunk/test/Feature/load_module.ll (original)
> +++ llvm/trunk/test/Feature/load_module.ll Sun Aug  4 18:55:24 2013
> @@ -2,7 +2,6 @@
>  ; RUN: opt < %s -load=%llvmshlibdir/LLVMHello%shlibext -hello \
>  ; RUN:   -disable-output 2>&1 | grep Hello
>  ; REQUIRES: loadable_module
> -; XFAIL: lto_on_osx
>  ; FIXME: On Cygming, it might fail without building LLVMHello manually.
>
>  @junk = global i32 0
>
> Modified: llvm/trunk/test/lit.cfg
> URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/test/lit.cfg?rev=187711&r1=187710&r2=187711&view=diff
> ==============================================================================
> --- llvm/trunk/test/lit.cfg (original)
> +++ llvm/trunk/test/lit.cfg Sun Aug  4 18:55:24 2013
> @@ -264,10 +264,6 @@ else:
>  if loadable_module:
>      config.available_features.add('loadable_module')
>
> -# LTO on OS X
> -if config.lto_is_enabled == "1" and platform.system() == "Darwin":
> -    config.available_features.add('lto_on_osx')
> -
>  # Sanitizers.
>  if config.llvm_use_sanitizer == "Address":
>      config.available_features.add("asan")
>
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits



More information about the llvm-commits mailing list