[llvm] r188032 - [lit] Eliminate parent argument from TestingConfig.frompath(), which is effectively unused.

Daniel Dunbar daniel at zuster.org
Thu Aug 8 17:08:46 PDT 2013


Author: ddunbar
Date: Thu Aug  8 19:08:46 2013
New Revision: 188032

URL: http://llvm.org/viewvc/llvm-project?rev=188032&view=rev
Log:
[lit] Eliminate parent argument from TestingConfig.frompath(), which is effectively unused.

Modified:
    llvm/trunk/utils/lit/lit/LitConfig.py
    llvm/trunk/utils/lit/lit/TestingConfig.py
    llvm/trunk/utils/lit/lit/discovery.py

Modified: llvm/trunk/utils/lit/lit/LitConfig.py
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/utils/lit/lit/LitConfig.py?rev=188032&r1=188031&r2=188032&view=diff
==============================================================================
--- llvm/trunk/utils/lit/lit/LitConfig.py (original)
+++ llvm/trunk/utils/lit/lit/LitConfig.py Thu Aug  8 19:08:46 2013
@@ -73,7 +73,7 @@ class LitConfig:
         if self.debug:
             self.note('load_config from %r' % path)
         return lit.TestingConfig.TestingConfig.frompath(
-            path, config.parent, self, mustExist = True, config = config)
+            path, config, self, mustExist = True)
 
     def getBashPath(self):
         """getBashPath - Get the path to 'bash'"""

Modified: llvm/trunk/utils/lit/lit/TestingConfig.py
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/utils/lit/lit/TestingConfig.py?rev=188032&r1=188031&r2=188032&view=diff
==============================================================================
--- llvm/trunk/utils/lit/lit/TestingConfig.py (original)
+++ llvm/trunk/utils/lit/lit/TestingConfig.py Thu Aug  8 19:08:46 2013
@@ -9,7 +9,14 @@ class TestingConfig:
     """
 
     @staticmethod
-    def frompath(path, parent, litConfig, mustExist, config = None):
+    def frompath(path, config, litConfig, mustExist):
+        """
+        frompath(path, config, litConfig, mustExist) -> TestingConfig
+
+        Load the configuration module at the provided path into the given config
+        object (or create a new one if None is provided) and return the config.
+        """
+
         if config is None:
             # Set the environment based on the command line arguments.
             environment = {
@@ -38,7 +45,7 @@ class TestingConfig:
                 if litConfig.valgrindLeakCheck:
                     available_features.append('vg_leak')
 
-            config = TestingConfig(parent,
+            config = TestingConfig(None,
                                    name = '<unnamed>',
                                    suffixes = set(),
                                    test_format = None,

Modified: llvm/trunk/utils/lit/lit/discovery.py
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/utils/lit/lit/discovery.py?rev=188032&r1=188031&r2=188032&view=diff
==============================================================================
--- llvm/trunk/utils/lit/lit/discovery.py (original)
+++ llvm/trunk/utils/lit/lit/discovery.py Thu Aug  8 19:08:46 2013
@@ -83,9 +83,8 @@ def getLocalConfig(ts, path_in_suite, li
         cfgpath = os.path.join(source_path, litConfig.local_config_name)
         if litConfig.debug:
             litConfig.note('loading local config %r' % cfgpath)
-        return TestingConfig.frompath(cfgpath, parent, litConfig,
-                                    mustExist = False,
-                                    config = parent.clone(cfgpath))
+        return TestingConfig.frompath(cfgpath, parent.clone(cfgpath), litConfig,
+                                      mustExist = False)
 
     def search(path_in_suite):
         key = (ts, path_in_suite)





More information about the llvm-commits mailing list