[PATCH] Improve isPotentiallyReachable

Nick Lewycky nlewycky at google.com
Thu Aug 8 11:57:07 PDT 2013


Ping!

This is only 200 lines because of code moving, but is not hard to
understand, nor does it need Chandler to review. I only cc'd him because I
think this fixes/obviates the rest of his comments on the previous
isPotentiallyReachable patch.

Nick

On 31 July 2013 00:14, Nick Lewycky <nlewycky at google.com> wrote:

> This patch fixes a missed-opportunity in isPotentiallyReachable where the
> From and To instructions are in the same non-entry block, and LoopInfo is
> not provided. The addition to the testcase demonstrates.
>
> This also moves some code around, providing both Instruction* and
> BasicBlock* overloads, and making the former forward to the block-only
> implementation.
>
> http://llvm-reviews.chandlerc.com/D1247
>
> Files:
>   lib/Analysis/CFG.cpp
>   include/llvm/Analysis/CFG.h
>   unittests/Analysis/CFGTest.cpp
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20130808/b839c254/attachment.html>


More information about the llvm-commits mailing list