[llvm] r187874 - Add support for linking against a curses library when available and

[Chris Lattner]

On Aug 7, 2013, at 8:34 AM, Chandler Carruth <chandlerc at gmail.com> wrote:
> You can always pass the flag. This just requires a system library to autodetect that system's color support which doesn't seem unreasonable.
> 
> The test against the string "dumb" doesn't really make any sense to me. The TERM environment variable is only really meaningful as a key into termcaps or term info which is what we're now querying.
> 

I think that James' point here is that this is a regression for systems that don't autodetect color support.  It might be reasonable for systems to do this, but until someone implements support in libSupport for detecting them, you're regressing the experience for people.  Telling them to just pass a flag to the compiler doesn't seem like the right thing.

-Chris


-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20130807/e3cba002/attachment.html>