[PATCH] Disable inlining between sanitized and non-sanitized functions

Evgeniy Stepanov eugenis at google.com
Wed Aug 7 03:33:27 PDT 2013



================
Comment at: test/Transforms/Inline/attributes.ll:4
@@ +3,3 @@
+
+; Test that different values of sanitizer attribute prevent inlining.
+
----------------
Chandler Carruth wrote:
> Rather than this generic comment that isn't terribly clear, I would document the specific invariant you're checking where you enforce it. For example:
> 
>     ; Check that an alwaysinline sanitized callee is still inlined
>     call void test_alwaysinline_sanitize_address_callee()
>   ; CHECK-NOT: call void test_alwaysinline_sanitize_address_callee
> 
> 
> 
> 
> As I've done here, you should also name the test functions after them: test_no_attr_callee, test_no_attr_caller, test_sanitize_address_callee, etc.
There are too many individual checks to document them all (we've got N^2 checks for N kinds of behavior under test). I've made the comments more detailed and moved them closer to the corresponding checks.


http://llvm-reviews.chandlerc.com/D1035



More information about the llvm-commits mailing list