[llvm] r187868 - Remove the assertion for now. This breaks lld.

Dmitri Gribenko gribozavr at gmail.com
Wed Aug 7 00:12:08 PDT 2013

Author: gribozavr
Date: Wed Aug  7 02:12:08 2013
New Revision: 187868

URL: http://llvm.org/viewvc/llvm-project?rev=187868&view=rev
Remove the assertion for now.  This breaks lld.

lld has a hashtable with StringRef keys; it needs to iterate over the keys in
*insertion* order.  This is currently implemented as std::vector<StringRef> +
DenseMap<StringRef, T>.  This will probably need a proper
DenseMapInfo<StringRef> if we don't want to lose memory/performance by
migrating to a different data structure.


Modified: llvm/trunk/include/llvm/ADT/DenseMap.h
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/include/llvm/ADT/DenseMap.h?rev=187868&r1=187867&r2=187868&view=diff
--- llvm/trunk/include/llvm/ADT/DenseMap.h (original)
+++ llvm/trunk/include/llvm/ADT/DenseMap.h Wed Aug  7 02:12:08 2013
@@ -606,9 +606,6 @@ public:
   void init(unsigned InitBuckets) {
-    assert(!KeyInfoT::isEqual(this->getEmptyKey(), this->getTombstoneKey()) &&
-           "Bad implementation of KeyInfoT: empty key and tombstone key "
-           "should be different");
     if (allocateBuckets(InitBuckets)) {
     } else {

More information about the llvm-commits mailing list