[llvm] r187853 - [lit] Use more modern syntax for constructing exceptions.

Daniel Dunbar daniel at zuster.org
Tue Aug 6 20:15:11 PDT 2013


Author: ddunbar
Date: Tue Aug  6 22:15:10 2013
New Revision: 187853

URL: http://llvm.org/viewvc/llvm-project?rev=187853&view=rev
Log:
[lit] Use more modern syntax for constructing exceptions.

Modified:
    llvm/trunk/utils/lit/lit/ShCommands.py
    llvm/trunk/utils/lit/lit/ShUtil.py
    llvm/trunk/utils/lit/lit/TestRunner.py

Modified: llvm/trunk/utils/lit/lit/ShCommands.py
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/utils/lit/lit/ShCommands.py?rev=187853&r1=187852&r2=187853&view=diff
==============================================================================
--- llvm/trunk/utils/lit/lit/ShCommands.py (original)
+++ llvm/trunk/utils/lit/lit/ShCommands.py Tue Aug  6 22:15:10 2013
@@ -20,14 +20,14 @@ class Command:
             elif '"' not in arg and '$' not in arg:
                 quoted = '"%s"' % arg
             else:
-                raise NotImplementedError,'Unable to quote %r' % arg
+                raise NotImplementedError('Unable to quote %r' % arg)
             print >>file, quoted,
 
             # For debugging / validation.
             import ShUtil
             dequoted = list(ShUtil.ShLexer(quoted).lex())
             if dequoted != [arg]:
-                raise NotImplementedError,'Unable to quote %r' % arg
+                raise NotImplementedError('Unable to quote %r' % arg)
 
         for r in self.redirects:
             if len(r[0]) == 1:
@@ -54,7 +54,7 @@ class Pipeline:
 
     def toShell(self, file, pipefail=False):
         if pipefail != self.pipe_err:
-            raise ValueError,'Inconsistent "pipefail" attribute!'
+            raise ValueError('Inconsistent "pipefail" attribute!')
         if self.negate:
             print >>file, '!',
         for cmd in self.commands:

Modified: llvm/trunk/utils/lit/lit/ShUtil.py
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/utils/lit/lit/ShUtil.py?rev=187853&r1=187852&r2=187853&view=diff
==============================================================================
--- llvm/trunk/utils/lit/lit/ShUtil.py (original)
+++ llvm/trunk/utils/lit/lit/ShUtil.py Tue Aug  6 22:15:10 2013
@@ -116,9 +116,11 @@ class ShLexer:
         reference = self.lex_arg_slow(c)
         if res is not None:
             if res != reference:
-                raise ValueError,"Fast path failure: %r != %r" % (res, reference)
+                raise ValueError("Fast path failure: %r != %r" % (
+                        res, reference))
             if self.pos != end:
-                raise ValueError,"Fast path failure: %r != %r" % (self.pos, end)
+                raise ValueError("Fast path failure: %r != %r" % (
+                        self.pos, end))
         return reference
         
     def lex_arg(self, c):
@@ -186,9 +188,9 @@ class ShParser:
     def parse_command(self):
         tok = self.lex()
         if not tok:
-            raise ValueError,"empty command!"
+            raise ValueError("empty command!")
         if isinstance(tok, tuple):
-            raise ValueError,"syntax error near unexpected token %r" % tok[0]
+            raise ValueError("syntax error near unexpected token %r" % tok[0])
         
         args = [tok]
         redirects = []
@@ -213,7 +215,7 @@ class ShParser:
             op = self.lex()
             arg = self.lex()
             if not arg:
-                raise ValueError,"syntax error near token %r" % op[0]
+                raise ValueError("syntax error near token %r" % op[0])
             redirects.append((op, arg))
 
         return Command(args, redirects)
@@ -235,7 +237,8 @@ class ShParser:
             assert isinstance(operator, tuple) and len(operator) == 1
 
             if not self.look():
-                raise ValueError, "missing argument to operator %r" % operator[0]
+                raise ValueError(
+                    "missing argument to operator %r" % operator[0])
             
             # FIXME: Operator precedence!!
             lhs = Seq(lhs, operator[0], self.parse_pipeline())

Modified: llvm/trunk/utils/lit/lit/TestRunner.py
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/utils/lit/lit/TestRunner.py?rev=187853&r1=187852&r2=187853&view=diff
==============================================================================
--- llvm/trunk/utils/lit/lit/TestRunner.py (original)
+++ llvm/trunk/utils/lit/lit/TestRunner.py Tue Aug  6 22:15:10 2013
@@ -66,7 +66,7 @@ def executeShCmd(cmd, cfg, cwd, results)
                 res = executeShCmd(cmd.rhs, cfg, cwd, results)
             return res
 
-        raise ValueError,'Unknown shell command: %r' % cmd.op
+        raise ValueError('Unknown shell command: %r' % cmd.op)
 
     assert isinstance(cmd, ShUtil.Pipeline)
     procs = []





More information about the llvm-commits mailing list