[PATCH] Implemented llvm::sys::locale::columnWidth and isPrint for the case of generic UTF8-capable terminal.

Dmitri Gribenko gribozavr at gmail.com
Mon Aug 5 23:20:48 PDT 2013



================
Comment at: lib/Support/LocaleGeneric.inc:40
@@ +39,3 @@
+///   * surrogates (category = Cs);
+///   * unassigned characters (category = Cn).
+/// \return true if the character is considered printable.
----------------
This change makes sense, but the list of unassigned characters will probably change in future versions of the unicode standard.  Updating this list might become a maintenance issue.

Stepping back a bit, why can't we just rely on iswprint() here?



http://llvm-reviews.chandlerc.com/D1253



More information about the llvm-commits mailing list