[PATCH] Add support for DebugFission to DWARF parser

Eric Christopher echristo at gmail.com
Mon Aug 5 12:04:53 PDT 2013


  Few questions inline, otherwise looks pretty good.


================
Comment at: include/llvm/DebugInfo/DIContext.h:127
@@ +126,3 @@
+  enum DIContextKind {
+    DICK_DWARF
+  };
----------------
Unfortunate naming in english. How about CK_DWARF?

================
Comment at: lib/DebugInfo/DWARFContext.h:30
@@ -29,3 +29,3 @@
 class DWARFContext : public DIContext {
-  SmallVector<DWARFCompileUnit, 1> CUs;
+  SmallVector<DWARFCompileUnit *, 1> CUs;
   OwningPtr<DWARFDebugAbbrev> Abbrev;
----------------
Consider breaking this part out first in a separate patch? Also, since there's a single DWO for a single compile unit I'm not sure about the change to pointer as far as relevance to this patch. Can you give a bit more explanation here?


http://llvm-reviews.chandlerc.com/D1164



More information about the llvm-commits mailing list