[lld] r187670 - Use report_fatal_error() instead of llvm_unreachable() to show broken input file error.

Sean Silva silvas at purdue.edu
Mon Aug 5 11:58:51 PDT 2013


On Mon, Aug 5, 2013 at 11:51 AM, Richard <legalize at xmission.com> wrote:

>
> In article <BB5668CC-919A-406F-8531-E9B21E16E7C2 at apple.com>,
>     Nick Kledzik <kledzik at apple.com> writes:
>
> > I have similar issues with the darwin linker.  In lots of places I have
> > asserts which are really checking object file content issues.  Users of
> the
> > linker freak out when a malformed object file causes the linker to
> > crash/assert.  It would be much better if the parsing code returned an
> > error up the call chain so that the driver could  print out the path to
> the
> > malformed object file.
>
> Is there any reason we aren't using exceptions instead of error codes
> here?
>

<http://llvm.org/docs/CodingStandards.html#do-not-use-rtti-or-exceptions>

-- Sean Silva
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20130805/93eaec68/attachment.html>


More information about the llvm-commits mailing list