PATCH: SelectionDAG: Use MVT::i32 for vector indices

Tom Stellard tom at stellard.net
Mon Aug 5 10:20:29 PDT 2013


On Mon, Aug 05, 2013 at 10:13:22AM -0700, Evan Cheng wrote:
> The original patch seems reasonable. What concerns did reviewers have?
> 

The only feedback I received on the original patch was that I should use
MVT::i32 everywhere instead of using the TargetLowering callback, but
as Duncan pointed out, that won't work for targets where MVT:i32 is not
a legal type.

It appears that a few people are in favor of my original approach, so
all I really need is for someone to look over the patch and give me a
LGTM if there are no concerns with the implementation.

-Tom


> Evan
> 
> On Aug 1, 2013, at 7:34 AM, Tom Stellard <tom at stellard.net> wrote:
> 
> > On Wed, Jul 31, 2013 at 10:09:03PM -0700, Owen Anderson wrote:
> >> 
> >> On Jul 31, 2013, at 7:25 PM, Tom Stellard <tom at stellard.net> wrote:
> >> 
> >>>> 
> >>>> The first version of this patch that I wrote:
> >>>> http://lists.cs.uiuc.edu/pipermail/llvm-commits/Week-of-Mon-20130715/181799.html
> >>>> added TargetLowering::getVectorIdxTy() which targets could use to specify
> >>>> whatever type the wanted.  What do you think of using the version one patch
> >>>> instead?
> >>>> 
> >>> 
> >>> Ping.
> >> 
> >> FWIW, I prefer the approach using a target-specified type.
> >> 
> > 
> > Thanks Owen,
> > 
> > Do you any comments on my original patch?
> > 
> > http://lists.cs.uiuc.edu/pipermail/llvm-commits/Week-of-Mon-20130715/181799.html
> > 
> > -Tom
> > _______________________________________________
> > llvm-commits mailing list
> > llvm-commits at cs.uiuc.edu
> > http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
> 



More information about the llvm-commits mailing list