[PATCH] Option parsing: recognize the special -- token

Hans Wennborg hans at chromium.org
Fri Aug 2 14:11:31 PDT 2013


  > I hope none have built up such a dependency. To me, it is essential that all the drivers work as this patch makes them. I actually wonder if this was a regression when we switched to the common parsing implementation. (It seems unlikely).
  >
  > GCC-compatibility cannot be impacted by this because passing '--' to GCC results in a hard error.
  >
  > So I think we should make this change, and see if anyone screams. We should also probably file a bug against GCC to get them to implement equivalent behavior.

  Sounds good to me.


================
Comment at: lib/Option/OptTable.cpp:275
@@ -257,3 +274,3 @@
       ++Index;
       continue;
     }
----------------
Reid Kleckner wrote:
> I think this would probably be cleaner as an inner loop followed by a break.
Will do.


http://llvm-reviews.chandlerc.com/D1274



More information about the llvm-commits mailing list