[PATCH] Fix ARM LNT test-suite bot

Renato Golin renato.golin at linaro.org
Fri Aug 2 05:22:09 PDT 2013


Nadav,

This patch fixes *ALL* test-suite problems! :D

Description:

This patch fixes the multiple breakages on ARM test-suite after the SLP
vectorizer was introduced by default on O3. The problem was a missing
legalization of the vector types on ARMTTI::getCmpSelInstrCost(). We
might have to review all cost functions for the proper legalization
of types to avoid problems like these in the future.

The cost of boolean vector comparison changed radically due to this patch,
which may be better (or not), depending on how the back-end will lower
these selects. Needs further investigation as well.

Arnold,

If the new costs are totally wrong, we might need further impediments and
hard-code high costs on getCmpSelInstrCost(). Let me know if it rings a
bell.

cheers,
--renato
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20130802/c9e9018a/attachment.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: armtt.patch
Type: application/octet-stream
Size: 5197 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20130802/c9e9018a/attachment.obj>


More information about the llvm-commits mailing list