[PATCH] NVPTX: remove stub instprinter

Tim Northover t.p.northover at gmail.com
Thu Aug 1 03:54:59 PDT 2013


Hi jholewinski,

When doing a clean build, I get messages from ranlib about the NVPTXAsmPrinter library containing no symbols. It appears to be completely empty, with its functionality subsumed into the CodeGen library (NVPTXAsmPrinter.cpp specifically).

The attached patch removes these files. Ok to commit, NVPTX people?

Cheers.

Tim.

http://llvm-reviews.chandlerc.com/D1255

Files:
  lib/Target/NVPTX/CMakeLists.txt
  lib/Target/NVPTX/InstPrinter/CMakeLists.txt
  lib/Target/NVPTX/InstPrinter/LLVMBuild.txt
  lib/Target/NVPTX/InstPrinter/Makefile
  lib/Target/NVPTX/InstPrinter/NVPTXInstPrinter.cpp
  lib/Target/NVPTX/LLVMBuild.txt
  lib/Target/NVPTX/MCTargetDesc/LLVMBuild.txt
  lib/Target/NVPTX/Makefile

Index: lib/Target/NVPTX/CMakeLists.txt
===================================================================
--- lib/Target/NVPTX/CMakeLists.txt
+++ lib/Target/NVPTX/CMakeLists.txt
@@ -32,5 +32,4 @@
 add_dependencies(LLVMNVPTXCodeGen intrinsics_gen)
 
 add_subdirectory(TargetInfo)
-add_subdirectory(InstPrinter)
 add_subdirectory(MCTargetDesc)
Index: lib/Target/NVPTX/InstPrinter/CMakeLists.txt
===================================================================
--- lib/Target/NVPTX/InstPrinter/CMakeLists.txt
+++ /dev/null
@@ -1,7 +0,0 @@
-include_directories( ${CMAKE_CURRENT_BINARY_DIR}/.. ${CMAKE_CURRENT_SOURCE_DIR}/.. )
-
-add_llvm_library(LLVMNVPTXAsmPrinter
-  NVPTXInstPrinter.cpp
-  )
-
-add_dependencies(LLVMNVPTXAsmPrinter NVPTXCommonTableGen)
Index: lib/Target/NVPTX/InstPrinter/LLVMBuild.txt
===================================================================
--- lib/Target/NVPTX/InstPrinter/LLVMBuild.txt
+++ /dev/null
@@ -1,23 +0,0 @@
-;===- ./lib/Target/NVPTX/InstPrinter/LLVMBuild.txt -------------*- Conf -*--===;
-;
-;                     The LLVM Compiler Infrastructure
-;
-; This file is distributed under the University of Illinois Open Source
-; License. See LICENSE.TXT for details.
-;
-;===------------------------------------------------------------------------===;
-;
-; This is an LLVMBuild description file for the components in this subdirectory.
-;
-; For more information on the LLVMBuild system, please see:
-;
-;   http://llvm.org/docs/LLVMBuild.html
-;
-;===------------------------------------------------------------------------===;
-
-[component_0]
-type = Library
-name = NVPTXAsmPrinter
-parent = NVPTX
-required_libraries = MC Support
-add_to_library_groups = NVPTX
Index: lib/Target/NVPTX/InstPrinter/Makefile
===================================================================
--- lib/Target/NVPTX/InstPrinter/Makefile
+++ /dev/null
@@ -1,15 +0,0 @@
-##===- lib/Target/NVPTX/AsmPrinter/Makefile ----------------*- Makefile -*-===##
-#
-#											The LLVM Compiler Infrastructure
-#
-# This file is distributed under the University of Illinois Open Source
-# License. See LICENSE.TXT for details.
-#
-##===----------------------------------------------------------------------===##
-LEVEL = ../../../..
-LIBRARYNAME = LLVMNVPTXAsmPrinter
-
-# Hack: we need to include 'main' ptx target directory to grab private headers
-CPP.Flags += -I$(PROJ_OBJ_DIR)/.. -I$(PROJ_SRC_DIR)/..
-
-include $(LEVEL)/Makefile.common
Index: lib/Target/NVPTX/InstPrinter/NVPTXInstPrinter.cpp
===================================================================
--- lib/Target/NVPTX/InstPrinter/NVPTXInstPrinter.cpp
+++ /dev/null
@@ -1 +0,0 @@
-// Placeholder
Index: lib/Target/NVPTX/LLVMBuild.txt
===================================================================
--- lib/Target/NVPTX/LLVMBuild.txt
+++ lib/Target/NVPTX/LLVMBuild.txt
@@ -16,7 +16,7 @@
 ;===------------------------------------------------------------------------===;
 
 [common]
-subdirectories = InstPrinter MCTargetDesc TargetInfo
+subdirectories = MCTargetDesc TargetInfo
 
 [component_0]
 type = TargetGroup
Index: lib/Target/NVPTX/MCTargetDesc/LLVMBuild.txt
===================================================================
--- lib/Target/NVPTX/MCTargetDesc/LLVMBuild.txt
+++ lib/Target/NVPTX/MCTargetDesc/LLVMBuild.txt
@@ -19,5 +19,5 @@
 type = Library
 name = NVPTXDesc
 parent = NVPTX
-required_libraries = MC NVPTXAsmPrinter NVPTXInfo Support
+required_libraries = MC NVPTXInfo Support
 add_to_library_groups = NVPTX
Index: lib/Target/NVPTX/Makefile
===================================================================
--- lib/Target/NVPTX/Makefile
+++ lib/Target/NVPTX/Makefile
@@ -18,6 +18,6 @@
 		NVPTXGenRegisterInfo.inc \
 		NVPTXGenSubtargetInfo.inc
 
-DIRS = InstPrinter TargetInfo MCTargetDesc
+DIRS = TargetInfo MCTargetDesc
 
 include $(LEVEL)/Makefile.common
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D1255.1.patch
Type: text/x-patch
Size: 3871 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20130801/a082880b/attachment.bin>


More information about the llvm-commits mailing list