[PATCH] Use a consistent generator's name for cmake invocations

Reid Kleckner rnk at google.com
Wed Jul 31 13:27:46 PDT 2013


LGTM


On Fri, Jul 26, 2013 at 6:20 AM, Simon Atanasyan <simon at atanasyan.com>wrote:

> Hi,
>
> When I try to cross-compile LLVM using cmake+ninja the process fails
> on building a native TableGen. The build.ninja file generated by cmake
> invokes cmake again without -G option. As a result cmake uses a
> default generator and creates Makefile instead of build.ninja for
> building native TableGen.
>
> The attached patch passes -G argument to cmake with the same
> generator's name as used for the initial cmake invocation.
>
> I'm not an expert in cmake, so could anybody review the patch before
> commit?
>
> Regards,
> Simon Atanasyan
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20130731/f6503f07/attachment.html>


More information about the llvm-commits mailing list