[PATCH] Fixed incorrect disassembly for MOV16o16a when using Intel syntax.

Richard Mitton richard at codersnotes.com
Tue Jul 30 18:45:54 PDT 2013


Yeah that makes sense, I just figured I'd wait to see if any of them 
actually made it in first :-)

Richard Mitton
richard at codersnotes.com

On 07/30/2013 06:38 PM, Eric Christopher wrote:
> If you're going to keep contributing then it seems reasonable at this
> point to ask for it as you've submitted a few good patches.
>
> -eric
>
> On Tue, Jul 30, 2013 at 6:35 PM, Richard Mitton <richard at codersnotes.com> wrote:
>> Nope.
>>
>> Richard Mitton
>> richard at codersnotes.com
>>
>> On 07/30/2013 06:33 PM, Craig Topper wrote:
>>
>> LGTM. Do you have commit access?
>>
>>
>> On Tue, Jul 30, 2013 at 6:00 PM, Richard Mitton <richard at codersnotes.com>
>> wrote:
>>>    Looks like my text editor randomly decided to change it's settings from
>>> spaces to tabs. Sorry, fixed now.
>>>
>>> http://llvm-reviews.chandlerc.com/D1241
>>>
>>> CHANGE SINCE LAST DIFF
>>>    http://llvm-reviews.chandlerc.com/D1241?vs=3088&id=3098#toc
>>>
>>> Files:
>>>    lib/Target/X86/X86InstrInfo.td
>>>
>>> Index: lib/Target/X86/X86InstrInfo.td
>>> ===================================================================
>>> --- lib/Target/X86/X86InstrInfo.td
>>> +++ lib/Target/X86/X86InstrInfo.td
>>> @@ -1079,16 +1079,16 @@
>>>                      "mov{b}\t{$src, %al|AL, $src}", [], IIC_MOV_MEM>,
>>>                      Requires<[In32BitMode]>;
>>>   def MOV16o16a : Ii32 <0xA1, RawFrm, (outs), (ins offset16:$src),
>>> -                      "mov{w}\t{$src, %ax|AL, $src}", [], IIC_MOV_MEM>,
>>> OpSize,
>>> +                      "mov{w}\t{$src, %ax|AX, $src}", [], IIC_MOV_MEM>,
>>> OpSize,
>>>                        Requires<[In32BitMode]>;
>>>   def MOV32o32a : Ii32 <0xA1, RawFrm, (outs), (ins offset32:$src),
>>>                         "mov{l}\t{$src, %eax|EAX, $src}", [], IIC_MOV_MEM>,
>>>                        Requires<[In32BitMode]>;
>>>   def MOV8ao8 : Ii32 <0xA2, RawFrm, (outs offset8:$dst), (ins),
>>>                      "mov{b}\t{%al, $dst|$dst, AL}", [], IIC_MOV_MEM>,
>>>                     Requires<[In32BitMode]>;
>>>   def MOV16ao16 : Ii32 <0xA3, RawFrm, (outs offset16:$dst), (ins),
>>> -                      "mov{w}\t{%ax, $dst|$dst, AL}", [], IIC_MOV_MEM>,
>>> OpSize,
>>> +                      "mov{w}\t{%ax, $dst|$dst, AX}", [], IIC_MOV_MEM>,
>>> OpSize,
>>>                        Requires<[In32BitMode]>;
>>>   def MOV32ao32 : Ii32 <0xA3, RawFrm, (outs offset32:$dst), (ins),
>>>                         "mov{l}\t{%eax, $dst|$dst, EAX}", [], IIC_MOV_MEM>,
>>>
>>> _______________________________________________
>>> llvm-commits mailing list
>>> llvm-commits at cs.uiuc.edu
>>> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
>>>
>>
>>
>> --
>> ~Craig
>>
>>
>>
>> _______________________________________________
>> llvm-commits mailing list
>> llvm-commits at cs.uiuc.edu
>> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
>>




More information about the llvm-commits mailing list