[PATCH] Avoid FP conversions when calling bitcasted / alias functions

[Eli Friedman]

On Tue, Jul 30, 2013 at 12:32 PM, Matt Arsenault <arsenm2 at gmail.com> wrote:
>
> On Jul 30, 2013, at 12:14 , Eli Friedman <eli.friedman at gmail.com> wrote:
>
>>
>> ================
>> Comment at: lib/Transforms/InstCombine/InstCombineCalls.cpp:1176
>> @@ -1175,1 +1175,3 @@
>> +          Instruction::CastOps opcode
>> +            = CastInst::getCastOpcode(*AI, false, PTy, false);
>>           Args.push_back(Builder->CreateCast(opcode, *AI, PTy));
>> ----------------
>> Did you mean to change this to build a bitcast?
>
> I saw that one, but that was for calling as a varargs function, and those have weird promotion rules, so I figured I wouldn't touch it.

Okay.  In that case, please just don't modify the line at all.

Otherwise, LGTM.

-Eli