[llvm] r187271 - Move the default back to pipefail. I accidentally reverted it before.

[Eric Christopher]

On Tue, Jul 30, 2013 at 10:34 AM, Rick Foos <rfoos at codeaurora.org> wrote:
> On 07/30/2013 12:19 PM, Eric Christopher wrote:
>>>
>>> Thanks for calling me on that, yes the configure line is wrong.
>>>
>> Meant to be nicer than I think it came across. Sorry :)
>>
>>
>>> The --without's are coming from zorg ClangBuilder.
>>> I'll test a patch that removes the --without's for everyone, and one to
>>> correctly use triple on my buildslave.
>>>
>> Awesome.
>>
>>
>>> Here's what I'm telling zorg:
>>>          {'name' : "clang-hexagon-elf",
>>>           'slavenames' :["hexagon-build-02"],
>>>           'builddir' :"clang-hexagon-elf",
>>>           'factory' : ClangBuilder.getClangBuildFactory(
>>>                       triple='hexagon-unknown-elf',
>>>                       stage1_config='Release+Asserts',
>>> extra_configure_args=['--build=x86_64-linux-gnu',
>>> '--host=x86_64-linux-gnu',
>>> '--target=hexagon-unknown-elf',
>>> '--enable-targets=hexagon']
>>>                       )
>>>          },
>>> Here's what I'm getting in buildbot:
>>>
>>> ./configure --disable-bindings --build=x86_64-linux-gnu
>>> --host=x86_64-linux-gnu --target=hexagon-unknown-elf
>>> --enable-targets=hexagon
>>>
>>> (zorg is adding this)
>>> --build=hexagon-unknown-elf --host=hexagon-unknown-elf --without-llvmgcc
>>> --without-llvmgxx
>>>
>>> --prefix=/local/buildbot/workspace/hexagon-build-02/slave/clang-hexagon-elf/None
>>> --enable-optimized --enable-assertions
>>>
>> Ha. Lovely.
>>
>> Any reason for the --target option? I.e. why not just pass down the
>> -target to the run of the test tool?
>>
>> -eric
>
> I was trying to force hexagon with enable-targets and target. If I can force
> hexagon in the test tool run, yes that would be better. I don't see a
> configure option for this, is there something I'm missing?
>

Not a configure option, no, but you can use TEST_TARGET_FLAGS or
EXTRA_OPTIONS to your run of projects/test-suite to set things like
the target and the location of the sysroot. I think one of the arm
testers should work this way... if not, they probably should ;)

-eric

> -rick
>
>>>>> Thanks,
>>>>> Sebastian
>>>>>
>>>>> On Fri, Jul 26, 2013 at 6:22 PM, Rafael Espindola
>>>>> <rafael.espindola at gmail.com> wrote:
>>>>>>
>>>>>> Author: rafael
>>>>>> Date: Fri Jul 26 18:22:43 2013
>>>>>> New Revision: 187271
>>>>>>
>>>>>> URL: http://llvm.org/viewvc/llvm-project?rev=187271&view=rev
>>>>>> Log:
>>>>>> Move the default back to pipefail. I accidentally reverted it before.
>>>>>>
>>>>>> Modified:
>>>>>>       llvm/trunk/utils/lit/lit/TestingConfig.py
>>>>>>
>>>>>> Modified: llvm/trunk/utils/lit/lit/TestingConfig.py
>>>>>> URL:
>>>>>>
>>>>>> http://llvm.org/viewvc/llvm-project/llvm/trunk/utils/lit/lit/TestingConfig.py?rev=187271&r1=187270&r2=187271&view=diff
>>>>>>
>>>>>>
>>>>>> ==============================================================================
>>>>>> --- llvm/trunk/utils/lit/lit/TestingConfig.py (original)
>>>>>> +++ llvm/trunk/utils/lit/lit/TestingConfig.py Fri Jul 26 18:22:43 2013
>>>>>> @@ -48,7 +48,7 @@ class TestingConfig:
>>>>>>                                       test_source_root = None,
>>>>>>                                       excludes = [],
>>>>>>                                       available_features =
>>>>>> available_features,
>>>>>> -                                   pipefail = False)
>>>>>> +                                   pipefail = True)
>>>>>>
>>>>>>            if os.path.exists(path):
>>>>>>                # FIXME: Improve detection and error reporting of
>>>>>> errors
>>>>>> in the
>>>>>>
>>>>>>
>>>>>> _______________________________________________
>>>>>> llvm-commits mailing list
>>>>>> llvm-commits at cs.uiuc.edu
>>>>>> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
>>>>>
>>>>>
>>>>>
>>>>> --
>>>>> Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
>>>>> hosted by The Linux Foundation
>>>>> _______________________________________________
>>>>> llvm-commits mailing list
>>>>> llvm-commits at cs.uiuc.edu
>>>>> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
>>>>
>>>> _______________________________________________
>>>> llvm-commits mailing list
>>>> llvm-commits at cs.uiuc.edu
>>>> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
>>>
>>>
>>>
>>> --
>>> Rick Foos
>>>
>>> Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted
>>> by
>>> The Linux Foundation
>>>
>>> _______________________________________________
>>> llvm-commits mailing list
>>> llvm-commits at cs.uiuc.edu
>>> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
>
>
>
> --
> Rick Foos
> Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by
> The Linux Foundation
>