[llvm] r187271 - Move the default back to pipefail. I accidentally reverted it before.

[Rick Foos]

On 07/29/2013 05:52 PM, Eric Christopher wrote:
>> To reproduce, in a linux box, configure with:
>>
>> $ ../configure --disable-bindings --build=x86_64-linux-gnu
>> --host=x86_64-linux-gnu --target=hexagon-unknown-elf
>> --enable-targets=hexagon --build=hexagon-unknown-elf
>> --host=hexagon-unknown-elf --without-llvmgcc --without-llvmgxx
>> --enable-optimized --enable-assertions
>> $ make && make check-all
>>
> FWIW your configure line is completely wrong :)
>
> --host/--target/--build shouldn't be set to hexagon-elf for a generic
> linux build... well, you've got it set up twice which is just even
> weirder.
>
> Also --without-llvmgcc/without-llvmgxx were removed a long time ago :)
>
> -eric
Hi Eric,

Thanks for calling me on that, yes the configure line is wrong.

The --without's are coming from zorg ClangBuilder.
I'll test a patch that removes the --without's for everyone, and one to 
correctly use triple on my buildslave.

--rick

Here's what I'm telling zorg:
         {'name' : "clang-hexagon-elf",
          'slavenames' :["hexagon-build-02"],
          'builddir' :"clang-hexagon-elf",
          'factory' : ClangBuilder.getClangBuildFactory(
                      triple='hexagon-unknown-elf',
                      stage1_config='Release+Asserts',
extra_configure_args=['--build=x86_64-linux-gnu',
'--host=x86_64-linux-gnu',
'--target=hexagon-unknown-elf',
'--enable-targets=hexagon']
                      )
         },
Here's what I'm getting in buildbot:
./configure --disable-bindings --build=x86_64-linux-gnu 
--host=x86_64-linux-gnu --target=hexagon-unknown-elf 
--enable-targets=hexagon

(zorg is adding this)
--build=hexagon-unknown-elf --host=hexagon-unknown-elf --without-llvmgcc 
--without-llvmgxx
--prefix=/local/buildbot/workspace/hexagon-build-02/slave/clang-hexagon-elf/None 

--enable-optimized --enable-assertions

>
>> Thanks,
>> Sebastian
>>
>> On Fri, Jul 26, 2013 at 6:22 PM, Rafael Espindola
>> <rafael.espindola at gmail.com> wrote:
>>> Author: rafael
>>> Date: Fri Jul 26 18:22:43 2013
>>> New Revision: 187271
>>>
>>> URL: http://llvm.org/viewvc/llvm-project?rev=187271&view=rev
>>> Log:
>>> Move the default back to pipefail. I accidentally reverted it before.
>>>
>>> Modified:
>>>      llvm/trunk/utils/lit/lit/TestingConfig.py
>>>
>>> Modified: llvm/trunk/utils/lit/lit/TestingConfig.py
>>> URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/utils/lit/lit/TestingConfig.py?rev=187271&r1=187270&r2=187271&view=diff
>>> ==============================================================================
>>> --- llvm/trunk/utils/lit/lit/TestingConfig.py (original)
>>> +++ llvm/trunk/utils/lit/lit/TestingConfig.py Fri Jul 26 18:22:43 2013
>>> @@ -48,7 +48,7 @@ class TestingConfig:
>>>                                      test_source_root = None,
>>>                                      excludes = [],
>>>                                      available_features = available_features,
>>> -                                   pipefail = False)
>>> +                                   pipefail = True)
>>>
>>>           if os.path.exists(path):
>>>               # FIXME: Improve detection and error reporting of errors in the
>>>
>>>
>>> _______________________________________________
>>> llvm-commits mailing list
>>> llvm-commits at cs.uiuc.edu
>>> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
>>
>>
>> --
>> Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
>> hosted by The Linux Foundation
>> _______________________________________________
>> llvm-commits mailing list
>> llvm-commits at cs.uiuc.edu
>> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits


-- 
Rick Foos
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by The Linux Foundation