[PATCH] MC: Support larger COFF string tables

Jay Foad jay.foad at gmail.com
Tue Jul 30 01:00:51 PDT 2013


On 30 July 2013 00:38, Chandler Carruth <chandlerc at google.com> wrote:
>
> On Wed, Jul 24, 2013 at 1:00 AM, Jay Foad <jay.foad at gmail.com> wrote:
>>
>>     if (StringTableEntry < 1e6) {
>>       ...
>>     } else if (StringTableEntry < 1e7) {
>
>
> Please don't use this pattern. These are floating point numbers rather than
> integers.

So? It will generate just as good code (if compiled with a decent
compiled like clang) and is much easier to comprehend.

Jay.



More information about the llvm-commits mailing list