[lld] r187390 - [PECOFF][Driver] Remove quotes from command line arguments.

Rui Ueyama ruiu at google.com
Mon Jul 29 17:21:27 PDT 2013


On Mon, Jul 29, 2013 at 5:16 PM, Chandler Carruth <chandlerc at google.com>wrote:

>
> On Mon, Jul 29, 2013 at 4:53 PM, Reid Kleckner <rnk at google.com> wrote:
>
>> The correct unquoting mechanism is probably the one used by
>> CommandLineToArgv(W).
>>
>> http://msdn.microsoft.com/en-us/library/windows/desktop/bb776391(v=vs.85).aspx
>>
>> http://msdn.microsoft.com/en-us/library/windows/desktop/17w5ykft(v=vs.85).aspx
>>
>> There's a FIXME to implement this algorithm in
>> llvm/lib/Support/CommandLine.cpp in TokenizeWindowsCommandLine().
>>
>
> It would be good to implement this generically and share the code...
>

Yup, I'll do that. That should be useful not only for the linker but also
for the compiler driver to parse @<filename>-style response file.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20130729/866e47e0/attachment.html>


More information about the llvm-commits mailing list