[llvm] r187223 - Re-add DataLayout pointer size convenience functions.

Duncan Sands duncan.sands at gmail.com
Sat Jul 27 11:21:27 PDT 2013


Hi Matt,

On 26/07/13 19:37, Matt Arsenault wrote:
> Author: arsenm
> Date: Fri Jul 26 12:37:20 2013
> New Revision: 187223
>
> URL: http://llvm.org/viewvc/llvm-project?rev=187223&view=rev
> Log:
> Re-add DataLayout pointer size convenience functions.
>
> These were reverted in r167222 along with the rest
> of the last different address space pointer size attempt.
> These will be used in later commits.
>
> Modified:
>      llvm/trunk/include/llvm/IR/DataLayout.h
>      llvm/trunk/lib/IR/DataLayout.cpp
>
...
> Modified: llvm/trunk/lib/IR/DataLayout.cpp
> URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/IR/DataLayout.cpp?rev=187223&r1=187222&r2=187223&view=diff
> ==============================================================================
> --- llvm/trunk/lib/IR/DataLayout.cpp (original)
> +++ llvm/trunk/lib/IR/DataLayout.cpp Fri Jul 26 12:37:20 2013
> @@ -507,6 +507,16 @@ std::string DataLayout::getStringReprese
>     return OS.str();
>   }
>
> +unsigned DataLayout::getPointerTypeSizeInBits(Type *Ty) const {
> +  assert(Ty->isPtrOrPtrVectorTy() &&
> +         "This should only be called with a pointer or pointer vector type");


> +
> +  if (Ty->isPointerTy())
> +    return getTypeSizeInBits(Ty);
> +
> +  Type *EleTy = cast<VectorType>(Ty)->getElementType();
> +  return getTypeSizeInBits(EleTy);

This could just be:

   return getTypeSizeInBits(Ty->getScalarType());

Ciao, Duncan.

> +}
>
>   /*!
>     \param abi_or_pref Flag that determines which alignment is returned. true
>
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
>




More information about the llvm-commits mailing list