[PATCH] Avoid FP conversions when calling bitcasted / alias functions

Matt Arsenault arsenm2 at gmail.com
Fri Jul 26 17:15:16 PDT 2013


On Jul 26, 2013, at 17:04 , Eli Friedman <eli.friedman at gmail.com> wrote:

> Something weird happened to the diff.
> 
> Does it really make sense to zext and/or trunc the input here?
> 
Sort of? I didn't really get why this code is here in the first place. I wast trying to preserve what it did except for the floating point part. It tries its best to call the underlying function with something valid when the types don't match. opt -lint says this is undefined (which should probably be fixed, since there are already other tests that check for specific behaviors here)

> While you're at it, you might as well get rid of CastInst::isCastable,
> because it isn't used anywhere else.





More information about the llvm-commits mailing list