[llvm] r187222 - Move this to the X86 directory, unfortunately the hashes are not

Fri Jul 26 13:12:46 PDT 2013

On Fri, Jul 26, 2013 at 11:33 AM, David Blaikie <dblaikie at gmail.com> wrote:
> On Fri, Jul 26, 2013 at 10:35 AM, Eric Christopher <echristo at gmail.com> wrote:
>> Author: echristo
>> Date: Fri Jul 26 12:35:47 2013
>> New Revision: 187222
>>
>> URL: http://llvm.org/viewvc/llvm-project?rev=187222&view=rev
>> Log:
>> Move this to the X86 directory, unfortunately the hashes are not
>> endian independent.
>
> Thought you'd been saying they were (one of the reasons for ULEB128 &
> all that) - is that a bug (in our code or in the DWARF spec for
> computing these hashes) or just the way it is?
>

I'm hoping a bug in my code somewhere.. I am going to investigate, I'm
just not sure what's going on at the moment. I'm also going to check
the gcc output some BE platform and look.

-eric

>>
>> Added:
>>     llvm/trunk/test/DebugInfo/X86/generate-odr-hash.ll
>>       - copied, changed from r187217, llvm/trunk/test/DebugInfo/generate-odr-hash.ll
>> Removed:
>>     llvm/trunk/test/DebugInfo/generate-odr-hash.ll
>>
>> Copied: llvm/trunk/test/DebugInfo/X86/generate-odr-hash.ll (from r187217, llvm/trunk/test/DebugInfo/generate-odr-hash.ll)
>> URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/test/DebugInfo/X86/generate-odr-hash.ll?p2=llvm/trunk/test/DebugInfo/X86/generate-odr-hash.ll&p1=llvm/trunk/test/DebugInfo/generate-odr-hash.ll&r1=187217&r2=187222&rev=187222&view=diff
>> ==============================================================================
>>     (empty)
>>
>> Removed: llvm/trunk/test/DebugInfo/generate-odr-hash.ll
>> URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/test/DebugInfo/generate-odr-hash.ll?rev=187221&view=auto
>> ==============================================================================
>> --- llvm/trunk/test/DebugInfo/generate-odr-hash.ll (original)
>> +++ llvm/trunk/test/DebugInfo/generate-odr-hash.ll (removed)
>> @@ -1,116 +0,0 @@
>> -; REQUIRES: object-emission
>> -
>> -; RUN: llc %s -o %t -filetype=obj -O0 -generate-odr-hash
>> -; RUN: llvm-dwarfdump -debug-dump=info %t | FileCheck %s
>> -;
>> -; Generated from:
>> -;
>> -; struct bar {};
>> -; struct bar b;
>> -; void foo(void) {
>> -;   struct baz {};
>> -;   baz b;
>> -; }
>> -; namespace echidna {
>> -; namespace capybara {
>> -; namespace mongoose {
>> -; class fluffy {
>> -;   int a;
>> -;   int b;
>> -; };
>> -; fluffy animal;
>> -; }
>> -; }
>> -; }
>> -; namespace {
>> -; struct walrus {};
>> -; }
>> -; walrus w;
>> -
>> -; Check that we generate a hash for bar, that it is a particular value and
>> -; that we don't generate a hash for baz or walrus.
>> -; CHECK: DW_TAG_structure_type
>> -; CHECK-NEXT: debug_str{{.*}}"bar"
>> -; CHECK: DW_AT_GNU_odr_signature [DW_FORM_data8] (0x200520c0d5b90eff)
>> -; CHECK: DW_TAG_namespace
>> -; CHECK-NEXT: debug_str{{.*}}"echidna"
>> -; CHECK: DW_TAG_namespace
>> -; CHECK-NEXT: debug_str{{.*}}"capybara"
>> -; CHECK: DW_TAG_namespace
>> -; CHECK-NEXT: debug_str{{.*}}"mongoose"
>> -; CHECK: DW_TAG_class_type
>> -; CHECK-NEXT: debug_str{{.*}}"fluffy"
>> -; CHECK: DW_AT_GNU_odr_signature [DW_FORM_data8]   (0x9a0124d5a0c21c52)
>> -; CHECK: DW_TAG_structure_type
>> -; CHECK-NEXT: debug_str{{.*}}"baz"
>> -; CHECK-NOT: DW_AT_GNU_odr_signature
>> -; FIXME: we may want to generate debug info for walrus, but still no hash.
>> -; CHECK-NOT: debug_str{{.*}}"walrus"
>> -
>> -
>> -%struct.bar = type { i8 }
>> -%"class.echidna::capybara::mongoose::fluffy" = type { i32, i32 }
>> -%struct.baz = type { i8 }
>> -
>> - at b = global %struct.bar zeroinitializer, align 1
>> - at _ZN7echidna8capybara8mongoose6animalE = global %"class.echidna::capybara::mongoose::fluffy" zeroinitializer, align 4
>> -
>> -; Function Attrs: nounwind uwtable
>> -define void @_Z3foov() #0 {
>> -entry:
>> -  %b = alloca %struct.baz, align 1
>> -  call void @llvm.dbg.declare(metadata !{%struct.baz* %b}, metadata !32), !dbg !40
>> -  ret void, !dbg !41
>> -}
>> -
>> -; Function Attrs: nounwind readnone
>> -declare void @llvm.dbg.declare(metadata, metadata) #1
>> -
>> -attributes #0 = { nounwind uwtable "less-precise-fpmad"="false" "no-frame-pointer-elim"="true" "no-frame-pointer-elim-non-leaf"="true" "no-infs-fp-math"="false" "no-nans-fp-math"="false" "stack-protector-buffer-size"="8" "unsafe-fp-math"="false" "use-soft-float"="false" }
>> -attributes #1 = { nounwind readnone }
>> -
>> -!llvm.dbg.cu = !{!0}
>> -!llvm.module.flags = !{!31}
>> -
>> -!0 = metadata !{i32 786449, metadata !1, i32 4, metadata !"clang version 3.4 (trunk 187152) (llvm/trunk 187150)", i1 false, metadata !"", i32 0, metadata !2, metadata !2, metadata !3, metadata !8, metadata !2, metadata !""} ; [ DW_TAG_compile_unit ] [/usr/local/google/home/echristo/tmp/bar.cpp] [DW_LANG_C_plus_plus]
>> -!1 = metadata !{metadata !"bar.cpp", metadata !"/usr/local/google/home/echristo/tmp"}
>> -!2 = metadata !{i32 0}
>> -!3 = metadata !{metadata !4}
>> -!4 = metadata !{i32 786478, metadata !1, metadata !5, metadata !"foo", metadata !"foo", metadata !"_Z3foov", i32 6, metadata !6, i1 false, i1 true, i32 0, i32 0, null, i32 256, i1 false, void ()* @_Z3foov, null, null, metadata !2, i32 6} ; [ DW_TAG_subprogram ] [line 6] [def] [foo]
>> -!5 = metadata !{i32 786473, metadata !1}          ; [ DW_TAG_file_type ] [/usr/local/google/home/echristo/tmp/bar.cpp]
>> -!6 = metadata !{i32 786453, i32 0, i32 0, metadata !"", i32 0, i64 0, i64 0, i64 0, i32 0, null, metadata !7, i32 0, i32 0} ; [ DW_TAG_subroutine_type ] [line 0, size 0, align 0, offset 0] [from ]
>> -!7 = metadata !{null}
>> -!8 = metadata !{metadata !9, metadata !17}
>> -!9 = metadata !{i32 786484, i32 0, null, metadata !"b", metadata !"b", metadata !"", metadata !5, i32 4, metadata !10, i32 0, i32 1, %struct.bar* @b, null} ; [ DW_TAG_variable ] [b] [line 4] [def]
>> -!10 = metadata !{i32 786451, metadata !1, null, metadata !"bar", i32 1, i64 8, i64 8, i32 0, i32 0, null, metadata !11, i32 0, null, null} ; [ DW_TAG_structure_type ] [bar] [line 1, size 8, align 8, offset 0] [def] [from ]
>> -!11 = metadata !{metadata !12}
>> -!12 = metadata !{i32 786478, metadata !1, metadata !10, metadata !"bar", metadata !"bar", metadata !"", i32 1, metadata !13, i1 false, i1 false, i32 0, i32 0, null, i32 320, i1 false, null, null, i32 0, metadata !16, i32 1} ; [ DW_TAG_subprogram ] [line 1] [bar]
>> -!13 = metadata !{i32 786453, i32 0, i32 0, metadata !"", i32 0, i64 0, i64 0, i64 0, i32 0, null, metadata !14, i32 0, i32 0} ; [ DW_TAG_subroutine_type ] [line 0, size 0, align 0, offset 0] [from ]
>> -!14 = metadata !{null, metadata !15}
>> -!15 = metadata !{i32 786447, i32 0, i32 0, metadata !"", i32 0, i64 64, i64 64, i64 0, i32 1088, metadata !10} ; [ DW_TAG_pointer_type ] [line 0, size 64, align 64, offset 0] [artificial] [from bar]
>> -!16 = metadata !{i32 786468}
>> -!17 = metadata !{i32 786484, i32 0, metadata !18, metadata !"animal", metadata !"animal", metadata !"_ZN7echidna8capybara8mongoose6animalE", metadata !5, i32 20, metadata !21, i32 0, i32 1, %"class.echidna::capybara::mongoose::fluffy"* @_ZN7echidna8capybara8mongoose6animalE, null} ; [ DW_TAG_variable ] [animal] [line 20] [def]
>> -!18 = metadata !{i32 786489, metadata !1, metadata !19, metadata !"mongoose", i32 14} ; [ DW_TAG_namespace ] [mongoose] [line 14]
>> -!19 = metadata !{i32 786489, metadata !1, metadata !20, metadata !"capybara", i32 13} ; [ DW_TAG_namespace ] [capybara] [line 13]
>> -!20 = metadata !{i32 786489, metadata !1, null, metadata !"echidna", i32 12} ; [ DW_TAG_namespace ] [echidna] [line 12]
>> -!21 = metadata !{i32 786434, metadata !1, metadata !18, metadata !"fluffy", i32 15, i64 64, i64 32, i32 0, i32 0, null, metadata !22, i32 0, null, null} ; [ DW_TAG_class_type ] [fluffy] [line 15, size 64, align 32, offset 0] [def] [from ]
>> -!22 = metadata !{metadata !23, metadata !25, metadata !26}
>> -!23 = metadata !{i32 786445, metadata !1, metadata !21, metadata !"a", i32 16, i64 32, i64 32, i64 0, i32 1, metadata !24} ; [ DW_TAG_member ] [a] [line 16, size 32, align 32, offset 0] [private] [from int]
>> -!24 = metadata !{i32 786468, null, null, metadata !"int", i32 0, i64 32, i64 32, i64 0, i32 0, i32 5} ; [ DW_TAG_base_type ] [int] [line 0, size 32, align 32, offset 0, enc DW_ATE_signed]
>> -!25 = metadata !{i32 786445, metadata !1, metadata !21, metadata !"b", i32 17, i64 32, i64 32, i64 32, i32 1, metadata !24} ; [ DW_TAG_member ] [b] [line 17, size 32, align 32, offset 32] [private] [from int]
>> -!26 = metadata !{i32 786478, metadata !1, metadata !21, metadata !"fluffy", metadata !"fluffy", metadata !"", i32 15, metadata !27, i1 false, i1 false, i32 0, i32 0, null, i32 320, i1 false, null, null, i32 0, metadata !30, i32 15} ; [ DW_TAG_subprogram ] [line 15] [fluffy]
>> -!27 = metadata !{i32 786453, i32 0, i32 0, metadata !"", i32 0, i64 0, i64 0, i64 0, i32 0, null, metadata !28, i32 0, i32 0} ; [ DW_TAG_subroutine_type ] [line 0, size 0, align 0, offset 0] [from ]
>> -!28 = metadata !{null, metadata !29}
>> -!29 = metadata !{i32 786447, i32 0, i32 0, metadata !"", i32 0, i64 64, i64 64, i64 0, i32 1088, metadata !21} ; [ DW_TAG_pointer_type ] [line 0, size 64, align 64, offset 0] [artificial] [from fluffy]
>> -!30 = metadata !{i32 786468}
>> -!31 = metadata !{i32 2, metadata !"Dwarf Version", i32 3}
>> -!32 = metadata !{i32 786688, metadata !4, metadata !"b", metadata !5, i32 9, metadata !33, i32 0, i32 0} ; [ DW_TAG_auto_variable ] [b] [line 9]
>> -!33 = metadata !{i32 786451, metadata !1, metadata !4, metadata !"baz", i32 7, i64 8, i64 8, i32 0, i32 0, null, metadata !34, i32 0, null, null} ; [ DW_TAG_structure_type ] [baz] [line 7, size 8, align 8, offset 0] [def] [from ]
>> -!34 = metadata !{metadata !35}
>> -!35 = metadata !{i32 786478, metadata !1, metadata !33, metadata !"baz", metadata !"baz", metadata !"", i32 7, metadata !36, i1 false, i1 false, i32 0, i32 0, null, i32 320, i1 false, null, null, i32 0, metadata !39, i32 7} ; [ DW_TAG_subprogram ] [line 7] [baz]
>> -!36 = metadata !{i32 786453, i32 0, i32 0, metadata !"", i32 0, i64 0, i64 0, i64 0, i32 0, null, metadata !37, i32 0, i32 0} ; [ DW_TAG_subroutine_type ] [line 0, size 0, align 0, offset 0] [from ]
>> -!37 = metadata !{null, metadata !38}
>> -!38 = metadata !{i32 786447, i32 0, i32 0, metadata !"", i32 0, i64 64, i64 64, i64 0, i32 1088, metadata !33} ; [ DW_TAG_pointer_type ] [line 0, size 64, align 64, offset 0] [artificial] [from baz]
>> -!39 = metadata !{i32 786468}
>> -!40 = metadata !{i32 9, i32 0, metadata !4, null}
>> -!41 = metadata !{i32 10, i32 0, metadata !4, null}
>>
>>
>> _______________________________________________
>> llvm-commits mailing list
>> llvm-commits at cs.uiuc.edu
>> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits