[llvm] r185716 - Add a higher level createTemporaryFile function.

[Rafael Espíndola]

On 25 July 2013 10:58, Hal Finkel <hfinkel at anl.gov> wrote:
> ----- Original Message -----
>> > When Suffix == "", this creates a file with a trailing '.', and
>> > while there is nothing functionally wrong with this, it does look
>> > a bit odd. Do you think that we could make this:
>> >
>> > Prefix + "-%%%%%%" + (Suffix.empty() ? StringRef("") :
>> > StringRef(".")) + Suffix
>> >
>> > Or something similar instead?
>>
>> Sure, what do you think of the attached patch?
>
> Thanks for doing this!
>
> +  ASSERT_TRUE(TempPath2.endswith(".temp"));

More or less. Just making sure we still add the '.' if the suffix is not empty.

> This is an unrelated test case improvement?
>
> Yea, looks fine to me!

187124



>  -Hal
>
>>
>> Cheers,
>> Rafael
>>
>
> --
> Hal Finkel
> Assistant Computational Scientist
> Leadership Computing Facility
> Argonne National Laboratory