[PATCH] Correct re-applying relocations on MIPS platforms

Rafael EspĂ­ndola rafael.espindola at gmail.com
Tue Jul 23 05:19:57 PDT 2013


On 22 July 2013 20:30, Petar Jovanovic <Petar.Jovanovic at imgtec.com> wrote:
> Hello everyone,
>
> here is a patch that corrects how multiple relocations are applied on MIPS.
>
> Similar to ARM change r182800, dynamic linker will reads bits/addends from
> the original object rather than from the object that might have been patched
> previously. For the purpose of relocations for MCJIT stubs on MIPS, we
> internally use otherwise unused MIPS relocations.
>
> The change also enables MCJIT unit tests for MIPS (EL/BE), and the following
> two tests now pass:
>
> - MCJITTest.return_global and
> - MCJITTest.multiple_functions.

The previous ones were already passing? I.E.,  with this patch all the
unit tests pass? If so, LGTM.

Cheers,
Rafael



More information about the llvm-commits mailing list